fix QuerySet.annotate() crash with combined expression #80
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
combined-expression-crash
branch
from
dce83f4 to
342d16d
Compare
WaVEV
reviewed
Jul 15, 2024
| @@ -83,7 +83,7 @@ def _make_result(self, entity, columns): | |||
| if column_alias is not None and column_alias != self.collection_name | |||
| else entity | |||
| ) | |||
| result.append(obj.get(name, col.field.get_default())) | |||
| result.append(obj.get(name)) | |||
There was a problem hiding this comment.
So, maybe is time to do obj[name] because None is a value, and returning it is a population ? or I am missing something?
There was a problem hiding this comment.
I think it's better to return None rather than fail with an exception here if a field doesn't exist in the document. For example, if a field is added to an existing model, we might not add that field to existing documents.
There was a problem hiding this comment.
🤔 , well so we are not managing migrations as the SQLs do, right?
There was a problem hiding this comment.
Correct. Most migration operations are no-op, at least for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fallback came from the inital commit of djangotoolbox, however, I don't think it's a good idea to populate model data that's not in the database.