-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-47159: Clarify write blocking recommendation on finalize cutover page #599
DOCSP-47159: Clarify write blocking recommendation on finalize cutover page #599
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions!
source/reference/cutover-process.txt
Outdated
For more information, see :ref:`c2c-verification`. | ||
|
||
.. step:: Enable application writes on the destination cluster. | ||
.. step:: If you did not start ``mongosync`` with :ref:`write-blocking <c2c-write-blocking>`, enable application writes on the destination cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user also only needs to do this step if they manually blocked writes on the dst. Could we update the step title to be something like "if you blocked writes on the destination cluster, enable application writes?" We can still keep the other note you added below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small suggestion. can LGTM right after!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.11 v1.11
# Navigate to the new working tree
cd .worktrees/backport-v1.11
# Create a new branch
git switch --create backport-599-to-v1.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07991f7bb43b68d321f8f7af2b41d3052186d4d0
# Push it to GitHub
git push --set-upstream origin backport-599-to-v1.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.11 Then, create a pull request where the |
…r page (#599) (#607) * init commit * rendering fix * render * clarity * change * change * remove link (cherry picked from commit 07991f7) Co-authored-by: Maya Raman <[email protected]>
…r page (#599) (#606) * init commit * rendering fix * render * clarity * change * change * remove link (cherry picked from commit 07991f7) Co-authored-by: Maya Raman <[email protected]>
…r page (#599) (#608) * init commit * rendering fix * render * clarity * change * change * remove link (cherry picked from commit 07991f7) Co-authored-by: Maya Raman <[email protected]>
https://jira.mongodb.org/browse/DOCSP-47159
Staging:
https://deploy-preview-599--docs-cluster-to-cluster-sync.netlify.app/reference/cutover-process/#if-you-manually-blocked-writes-on-the-destination-cluster-by-using---enable-application-writes-on-the-destination-cluster.