Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 2506068
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67aa7c4c4eca670008e435db
😎 Deploy Preview https://deploy-preview-599--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gmiller-mdb gmiller-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions!

For more information, see :ref:`c2c-verification`.

.. step:: Enable application writes on the destination cluster.
.. step:: If you did not start ``mongosync`` with :ref:`write-blocking <c2c-write-blocking>`, enable application writes on the destination cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user also only needs to do this step if they manually blocked writes on the dst. Could we update the step title to be something like "if you blocked writes on the destination cluster, enable application writes?" We can still keep the other note you added below

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small suggestion. can LGTM right after!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeff-allen-mongo jeff-allen-mongo merged commit 07991f7 into mongodb:master Feb 11, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
…r page (#599)

* init commit

* rendering fix

* render

* clarity

* change

* change

* remove link

(cherry picked from commit 07991f7)
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
…r page (#599)

* init commit

* rendering fix

* render

* clarity

* change

* change

* remove link

(cherry picked from commit 07991f7)
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
…r page (#599)

* init commit

* rendering fix

* render

* clarity

* change

* change

* remove link

(cherry picked from commit 07991f7)
Copy link

The backport to v1.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.11 v1.11
# Navigate to the new working tree
cd .worktrees/backport-v1.11
# Create a new branch
git switch --create backport-599-to-v1.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07991f7bb43b68d321f8f7af2b41d3052186d4d0
# Push it to GitHub
git push --set-upstream origin backport-599-to-v1.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.11

Then, create a pull request where the base branch is v1.11 and the compare/head branch is backport-599-to-v1.11.

@mayaraman19 mayaraman19 deleted the DOCSP-47159-clarify-write branch February 11, 2025 16:52
jwilson-mdb pushed a commit that referenced this pull request Feb 11, 2025
…r page (#599) (#607)

* init commit

* rendering fix

* render

* clarity

* change

* change

* remove link

(cherry picked from commit 07991f7)

Co-authored-by: Maya Raman <[email protected]>
jwilson-mdb pushed a commit that referenced this pull request Feb 11, 2025
…r page (#599) (#606)

* init commit

* rendering fix

* render

* clarity

* change

* change

* remove link

(cherry picked from commit 07991f7)

Co-authored-by: Maya Raman <[email protected]>
jwilson-mdb pushed a commit that referenced this pull request Feb 11, 2025
…r page (#599) (#608)

* init commit

* rendering fix

* render

* clarity

* change

* change

* remove link

(cherry picked from commit 07991f7)

Co-authored-by: Maya Raman <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants