This repository was archived by the owner on May 1, 2025. It is now read-only.
DOCSP-47109-document-minimum-privileges #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
suggested changes
Mar 11, 2025
There was a problem hiding this comment.
Thanks for these changes, @gmiller-mdb! I've noted a few issues for your consideration.
Thank you!
Joe
jmd-mongo
suggested changes
Mar 11, 2025
jmd-mongo
reviewed
Mar 11, 2025
There was a problem hiding this comment.
Hi @gmiller-mdb! It looks like are still some spacing issues, unfortunately. It looks to me like there are upwards of six spaces on indentation. Is it possible you may be using tabs?
Thank you!
Joe
jmd-mongo
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Thanks for these updates, @gmiller-mdb! This one LGTM at this point.
Thanks,
Joe
tdq45gj
suggested changes
Mar 12, 2025
gmiller-mdb
changed the title
tdq45gj
approved these changes
Mar 13, 2025
gmiller-mdb
added a commit
to gmiller-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 13, 2025
* DOCSP-47109-DOCSP-document-minimum-privileges * table stuff * table format * fix build error * spacing * actual spacing * changed spacing to 3 * re doing all of the spaces god * feedback (cherry picked from commit b907945)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmiller-mdb
added a commit
to gmiller-mdb/docs-cluster-to-cluster-sync
that referenced
this pull request
Mar 13, 2025
* DOCSP-47109-DOCSP-document-minimum-privileges * table stuff * table format * fix build error * spacing * actual spacing * changed spacing to 3 * re doing all of the spaces god * feedback (cherry picked from commit b907945)
gmiller-mdb
added a commit
that referenced
this pull request
Mar 13, 2025
gmiller-mdb
added a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.mongodb.org/browse/DOCSP-47109
Staging: https://deploy-preview-650--docs-cluster-to-cluster-sync.netlify.app/reference/permissions/