-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-46644: Stop balancer on a per-collection basis #670
DOCSP-46644: Stop balancer on a per-collection basis #670
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly LTGM, with a few questions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions–please let me know if you have any questions or if I can clarify anything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments for you, Maya. Mostly small suggestions to make the wording as clear as possible, and one larger structural suggestion to clarify the requirements for the destination cluster's balancer, so that piece doesn't get lost. Thanks for the back and forth on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM! I left a few non-blocking comments and suggestions just to make it as clean and clear as possible, but I'll leave those up to your judgement. Thanks for all your work on this Maya!
and you are not running ``mongosync`` with :ref:`namespace | ||
filtering <c2c-filtered-sync>`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and you are not running ``mongosync`` with :ref:`namespace | |
filtering <c2c-filtered-sync>`, | |
and you are running ``mongosync`` without :ref:`namespace | |
filtering <c2c-filtered-sync>`, |
See :ref:`disabling-balancer-filtered`. You can also fully disable | ||
the source cluster's balancer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! thanks for adding this.
filter, do not run :dbcommand:`shardCollection` on collections | ||
within the namespace filter. If you run :dbcommand:`shardCollection` on | ||
collections within the namespace filter during the migration, ``mongosync`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter, do not run :dbcommand:`shardCollection` on collections | |
within the namespace filter. If you run :dbcommand:`shardCollection` on | |
collections within the namespace filter during the migration, ``mongosync`` | |
filter, running :dbcommand:`shardCollection` on collections within the namespace filter during the migration causes ``mongosync`` to return |
If possible to make these two sentences into one I think it might be cleaner, but up to your judgement–if you like to be explicit "do not run X command" that's ok too.
If you are using a :ref:`namespace filter <c2c-filtered-sync>` | ||
and want to enable your source cluster's balancer for | ||
collections outside the namespace filter, | ||
use the following instructions before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the following instructions before | |
follow these instructions before |
starting ``mongosync``. This gives the cluster time to | ||
finish any in progress chunk migrations. | ||
- If the source or destination cluster is a sharded cluster | ||
and you are not running ``mongosync`` with :ref:`namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as other comment: I'd suggest "you are running mongosync without..."
- If you have enabled the source cluster's | ||
balancer, but disabled it for collections within the namespace | ||
filter, do not run :dbcommand:`shardCollection` on collections | ||
within the namespace filter. If you run :dbcommand:`shardCollection` on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as other comment on Behavior page–if possible to combine into one sentence to reduce repetition that would be great, but up to your discretion.
https://jira.mongodb.org/browse/DOCSP-46644
Staging: