-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-48653-Make-it-clear-the-embedded-verifier-is-on-by-default-for-sharded-clusters #696
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % one non-blocking nit! thanks for picking this up :-)
source/release-notes/1.10.txt
Outdated
|
||
- .. include:: /includes/verify-reversible-migrations.rst | ||
|
||
- ``mongosync`` now enables the embedded verifier on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] I think we can remove "now" for further conciseness/brevity!
supported collections. | ||
supported collections. Starting in version 1.9, ``mongosync`` enables | ||
the verifier by default on replica set clusters. In version 1.10, | ||
``mongosync`` enables the verifier by default on sharded clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be better to omit the 1.9 and instead say in a separate line something like: "mongosync enables the embedded verifier by default"
and then under it new in 1.10
Similar to how it is done below on this page I think where it says ".. versionadded:: 1.9"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks weird to me now. Maybe it needs to say "Starting in version 1.9, mongosync includes.." and then " mongosync enables the verifier by default on sharded clusters. \n new in version 1.10"
I'm not sure. Maybe @ajhuh-mdb can provide guidance
I think this looks fine as it currently since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds reasonable, thanks
… sharded clusters (mongodb#696) * commit * default * feedbakc * trying * remove space (cherry picked from commit bbc07b7)
… sharded clusters (mongodb#696) * commit * default * feedbakc * trying * remove space (cherry picked from commit bbc07b7)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
… sharded clusters (mongodb#696) * commit * default * feedbakc * trying * remove space (cherry picked from commit bbc07b7)
Backport to 1.10
Clarifies that embedded verifier is on by default for sharded clusters.
https://jira.mongodb.org/browse/DOCSP-48653