Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Mar 25, 2025

@mayaraman19 mayaraman19 changed the title commit DOCSP-48653: Make it clear the embedded verifier is on by default for sharded clusters Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 11f0e5c
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67e45e8144231f00080ed2b9
😎 Deploy Preview https://deploy-preview-696--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % one non-blocking nit! thanks for picking this up :-)


- .. include:: /includes/verify-reversible-migrations.rst

- ``mongosync`` now enables the embedded verifier on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] I think we can remove "now" for further conciseness/brevity!

@mayaraman19 mayaraman19 requested a review from rohshar March 26, 2025 14:55
supported collections.
supported collections. Starting in version 1.9, ``mongosync`` enables
the verifier by default on replica set clusters. In version 1.10,
``mongosync`` enables the verifier by default on sharded clusters.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be better to omit the 1.9 and instead say in a separate line something like: "mongosync enables the embedded verifier by default"
and then under it new in 1.10

Similar to how it is done below on this page I think where it says ".. versionadded:: 1.9"

@mayaraman19 mayaraman19 requested a review from rohshar March 26, 2025 17:29
Copy link
Collaborator

@rohshar rohshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks weird to me now. Maybe it needs to say "Starting in version 1.9, mongosync includes.." and then " mongosync enables the verifier by default on sharded clusters. \n new in version 1.10"

I'm not sure. Maybe @ajhuh-mdb can provide guidance

@ajhuh-mdb
Copy link
Collaborator

I think this looks fine as it currently since the versionadded:: 1.9 directive at the top clarifies that the embedded verifier (and all the page contents) were introduced in 1.9, whereas this "Starting in version 1.10" separates that information. I think if we included the New in version 1.10 at the bottom, it could be a bit confusing for users on what part of the paragraph applies only to 1.10.

@mayaraman19 mayaraman19 requested a review from rohshar March 28, 2025 15:40
Copy link
Collaborator

@rohshar rohshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, thanks

@mayaraman19 mayaraman19 merged commit bbc07b7 into mongodb:master Mar 28, 2025
4 checks passed
@mayaraman19 mayaraman19 changed the title DOCSP-48653: Make it clear the embedded verifier is on by default for sharded clusters DOCSP-48653-Make-it-clear-the-embedded-verifier-is-on-by-default-for-sharded-clusters Mar 28, 2025
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 28, 2025
… sharded clusters (mongodb#696)

* commit

* default

* feedbakc

* trying

* remove space

(cherry picked from commit bbc07b7)
mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 28, 2025
… sharded clusters (mongodb#696)

* commit

* default

* feedbakc

* trying

* remove space

(cherry picked from commit bbc07b7)
@mayaraman19
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.12
v1.11
v1.10

Questions ?

Please refer to the Backport tool documentation

mayaraman19 added a commit to mayaraman19/docs-cluster-to-cluster-sync that referenced this pull request Mar 28, 2025
… sharded clusters (mongodb#696)

* commit

* default

* feedbakc

* trying

* remove space

(cherry picked from commit bbc07b7)
mayaraman19 added a commit that referenced this pull request Mar 31, 2025
… sharded clusters (#696) (#710)

* commit

* default

* feedbakc

* trying

* remove space

(cherry picked from commit bbc07b7)
mayaraman19 added a commit that referenced this pull request Mar 31, 2025
… sharded clusters (#696) (#711)

* commit

* default

* feedbakc

* trying

* remove space

(cherry picked from commit bbc07b7)
mayaraman19 added a commit that referenced this pull request Mar 31, 2025
… sharded clusters (#696) (#709)

* commit

* default

* feedbakc

* trying

* remove space

(cherry picked from commit bbc07b7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants