Skip to content

Conversation

@ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Oct 14, 2024

DESCRIPTION

Updating schema screenshots to show new UI and use Atlas Sample Databases

Note: Some screenshots on this page did not need to be updated because the UI did not change.

STAGING

https://deploy-preview-680--docs-compass.netlify.app/schema/

JIRA

https://jira.mongodb.org/browse/DOCSP-41055

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 220b872
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/67127aed2366f40008765ed8
😎 Deploy Preview https://deploy-preview-680--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sarah-olson-mongodb sarah-olson-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ltran-mdb2!
LGTM

Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment! Thanks Lauren!

Comment on lines 58 to 60
- The ``categories`` field contains arrays of strings. The analysis
shows the minimum, maximum, and average array lengths.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compass still shows this information for arrays of strings. We probably shouldn't delete it from our docs, but it would be nice to tune this to the new example in the updated screenshots.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the text and the image accordingly!

@betsybutton
Copy link

It looks like this screenshot is still outdated:
image

@ltran-mdb2
Copy link
Collaborator Author

ltran-mdb2 commented Oct 18, 2024

It looks like this screenshot is still outdated: image

Just updated! @betsybutton Could you take another look?

Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lauren! LGTM

@ltran-mdb2 ltran-mdb2 merged commit 98718ec into mongodb:master Oct 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants