Skip to content

Conversation

@ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Oct 14, 2024

DESCRIPTION

Updating/auditing screenshots for the following pages to use new UI and Atlas Sample Databases:

https://www.mongodb.com/docs/compass/current/documents/insert/
https://www.mongodb.com/docs/compass/current/documents/modify/
https://www.mongodb.com/docs/compass/current/query/skip/
https://www.mongodb.com/docs/compass/current/query/limit/
https://www.mongodb.com/docs/compass/current/export-query-to-language/

Note(s) for reviewers:

The following pages already use sample databases and have updated UI:
https://www.mongodb.com/docs/compass/current/query/skip/
https://www.mongodb.com/docs/compass/current/query/limit/
https://www.mongodb.com/docs/compass/current/export-query-to-language/

/images/compass/expand-doc-json-view.png (shown in the JSON tab of the modify page) is updated in #678 so shows a different collection in staging but will show the restaurants collection when this PR is merged

STAGING

https://deploy-preview-681--docs-compass.netlify.app/documents/insert/
https://deploy-preview-681--docs-compass.netlify.app/documents/modify/

JIRA

https://jira.mongodb.org/browse/DOCSP-41056

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit d1d74fe
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/670d5ffb3f996000085f702e
😎 Deploy Preview https://deploy-preview-681--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ltran-mdb2 ltran-mdb2 changed the title Docsp 41056 DOCSP-41056-insert-and-modify-screenshot-update Oct 14, 2024
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @ltran-mdb2 ! These images look good. It looks like we might've missed one on the modify.txt page. The image for /images/compass/expand-doc-json-view.png (near line 137) still shows the old airplane collection.

@ltran-mdb2
Copy link
Collaborator Author

Hi @ajhuh-mdb , thanks for your review! I made a note of this in the PR description - /images/compass/expand-doc-json-view.png (shown in the JSON tab of the modify page) is updated in #678 so shows a different collection in staging but will show the restaurants collection when this PR is merged

@ltran-mdb2 ltran-mdb2 requested a review from ajhuh-mdb October 14, 2024 19:59
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Lauren!

@ltran-mdb2 ltran-mdb2 merged commit ea94d3f into mongodb:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants