-
Notifications
You must be signed in to change notification settings - Fork 81
DOCSP-19979-compass-telemetry-options #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-19979-compass-telemetry-options #697
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @jeff-allen-mongo ! I left a few comments and questions for your consideration.
source/settings/telemetry.txt
Outdated
| - The type of MongoDB deployment |compass-short| is connected to. For | ||
| example, Enterprise Edition, Community Edition, or Atlas Data Lake. | ||
|
|
||
| - User actions performed in |compass-short|, such as creating | ||
| collections and indexes. |compass-short| only tracks the general | ||
| action performed, and does not track field values or namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] for active voice, although I can see this being a case where passive voice is appropriate
| - The type of MongoDB deployment |compass-short| is connected to. For | |
| example, Enterprise Edition, Community Edition, or Atlas Data Lake. | |
| - User actions performed in |compass-short|, such as creating | |
| collections and indexes. |compass-short| only tracks the general | |
| action performed, and does not track field values or namespaces. | |
| - The type of MongoDB deployment that you connect |compass-short| to. For | |
| example, Enterprise Edition, Community Edition, or Atlas Data Lake. | |
| - Actions that you perform in |compass-short|, such as creating | |
| collections and indexes. |compass-short| only tracks the general | |
| action and does not track field values or namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these suggestions. I think using active voice works here, and this wording is an improvement!
source/settings/telemetry.txt
Outdated
| - IP addresses, hostnames, usernames, or credentials. | ||
|
|
||
| - Queries run in |compass-short|. | ||
|
|
||
| - Data stored in your MongoDB deployment. | ||
|
|
||
| - Personal identifiable information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all of these list items are fragments, I think we can leave out the periods re the style guideline on periods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
source/settings/telemetry.txt
Outdated
| .. procedure:: | ||
| :style: normal | ||
|
|
||
| .. step:: Open the Settings window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion] I would suggest adding a period to all of the step headings
| .. step:: Open the Settings window | |
| .. step:: Open the Settings window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
source/settings/telemetry.txt
Outdated
|
|
||
| You can toggle telemetry in either: | ||
|
|
||
| - The |compass-short| :ref:`Settings panel <compass-settings-reference>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] is there a reason why this is called the Settings panel in this line but the Settings window below? Is there a way to make this consistent?
| - The |compass-short| :ref:`Settings panel <compass-settings-reference>` | |
| - The |compass-short| :ref:`Settings panel <compass-settings-reference>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardized to "window".
source/settings/telemetry.txt
Outdated
| .. step:: In the :guilabel:`Settings` window, click :guilabel:`Privacy` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] do you think it would be helpful to add a screenshot of the window here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to omit the screenshot to help future-proof this in the event that the UI changes. I added a bit further clarification to say that "Privacy" is in the left pane of the window, which should hopefully ensure that users can find it.
|
@ltran-mdb2 thanks for the review! This is ready for another look whenever you have a chance. |
source/settings/telemetry.txt
Outdated
|
|
||
| |compass-short| *does not* track: | ||
|
|
||
| - IP addresses, hostnames, usernames, or credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually do track the hostname on connection in Compass. We use this information to identify an associated Atlas org when processing our telemetry data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense! Updating.
source/settings/telemetry.txt
Outdated
|
|
||
| - IP addresses, hostnames, usernames, or credentials | ||
|
|
||
| - Queries run in |compass-short| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will soon start tracking queries generated from the GenAI feature in an anonymized way. Maybe we can reword this so it says we won't be storing queries in a way that can be associated with the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DESCRIPTION
Add a task page for toggling Compass telemetry.
STAGING
Main content is on this new task page: Configure Telemetry Options
I also added links to the new page on these pages:
JIRA
https://jira.mongodb.org/browse/DOCSP-19979
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?