Skip to content

DOCSP-45739 Adds nonce in Auth Req to OIDC connection settings #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

DOCSP-45739 Adds nonce in Auth Req to OIDC connection settings #700

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
898fa7b
DOCSP-45739 Adds nonce in Auth Req to OIDC connection settings
jwilson-mdb Dec 3, 2024
40a5b46
Responds to feedback
jwilson-mdb Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/connect/advanced-connection-options/authentication-connection.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,13 @@
settings, |compass-short| uses the same proxy to connect to both
the cluster and identity provider.

* - Send a nonce in the Auth Code Request
- Optional. Includes a random nonce as a part of the auth code
request to prevent replay attacks. Enabled by default.

The nonce is an important security component. This setting should

Check failure on line 140 in source/connect/advanced-connection-options/authentication-connection.txt

View workflow job for this annotation

GitHub Actions / TDBX Vale rules 

[vale] reported by reviewdog 🐶
[MongoDB.AvoidSubjunctive] Avoid the subjunctive 'should'.

Raw Output:
{"message": "[MongoDB.AvoidSubjunctive] Avoid the subjunctive 'should'.", "location": {"path": "source/connect/advanced-connection-options/authentication-connection.txt", "range": {"start": {"line": 140, "column": 73}}}, "severity": "ERROR"}
only be disabled if it is not supported by your OIDC provider.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]

Consider a stronger phrasing. Spitballing: "Only disable this setting if it is not supported by your OIDC provider."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe, I think shortening it up and removing should improves it quite a bit.
I'll update this to incorporate your suggestion!


.. _x509:

X.509
Expand Down
Loading