Skip to content

DOCSP-45398-detail-large-number-queries #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 11, 2025
Merged

DOCSP-45398-detail-large-number-queries #742

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f78dd1c
add large integer limit note
shuangela Apr 9, 2025
a48e0c4
fix note syntax
shuangela Apr 9, 2025
6077959
formatting
shuangela Apr 9, 2025
b320eb0
change wording
shuangela Apr 9, 2025
01ba2ab
wording
shuangela Apr 9, 2025
eaea07f
grammar
shuangela Apr 9, 2025
2996c85
wording
shuangela Apr 9, 2025
dec6b5a
jp suggestion
shuangela Apr 10, 2025
e817b0d
bb feedback
shuangela Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions source/includes/large-number-note.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
.. note:: Large Integer Limitations

To query for integers larger than the JavaScript maximum integer size,
wrap the integer in string characters.

For example, to find all documents with a ``number`` value of ``507550989629521900``, use
this query filter:

.. code-block:: javascript

{ "number": "507550989629521900" }
Copy link

@betsybutton betsybutton Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example doesn't actually work. It's important to mention the need for NumberLong in the example. This is how Compass knows the type to search for. In the example given in the current draft, Compass would interpret the search value as a string, not as a Long (aka large integer).

For example, { restaurant_id: NumberLong(507550989629521900) } would not work, but { restaurant_id: NumberLong("507550989629521900") } would work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the clarification! I'll change the example

2 changes: 2 additions & 0 deletions source/query/filter.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ Set Query Filter
:lightbox:
:alt: Results of applying a query filter

.. include:: /includes/large-number-note.rst

Examples
--------

Expand Down
Loading