-
Notifications
You must be signed in to change notification settings - Fork 7
DOCSP-46866: Cleanup #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 27 commits
b6e726d
c2bd528
3773f3c
2c6b517
6761c1f
6d525b3
6f1cb6f
4e5ef03
faead26
9d3d5ba
587330f
4848f5e
abbf2db
2cc10db
aee2395
49f639b
1766926
6f10dcf
ede0d4d
291ec54
ada3826
c02c87c
870f278
394dcd3
2651304
45edee1
1aff09e
2774a99
77a0ab3
5468bbb
0a2f701
fb2645c
b3a18e9
86596ca
b7a9118
6bbdc82
e7d69e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ to read data from the ``sample_mflix`` database. | |
.. procedure:: | ||
:style: connected | ||
|
||
.. step:: Query the "users" collection for a specified email | ||
.. step:: Query the users collection for a specified email | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why the removal of quotes? Should this be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Usually we format collection names without quotes, monospaced (like here). But we also don't use monospace text in headers. However since this is a step, not a header, I'll change to |
||
|
||
Start a Python shell by running the following command: | ||
|
||
|
@@ -42,7 +42,7 @@ to read data from the ``sample_mflix`` database. | |
|
||
<Viewer: Khal Drogo> | ||
|
||
.. step:: Query the "movies" collection for specified runtime values | ||
.. step:: Query the movies collection for specified runtime values | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
|
||
Run the following code to query the ``sample_mflix.movies`` | ||
collection for movies that have a ``runtime`` value less than | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ and delete functions on your model objects. | |
:language: python | ||
:copyable: | ||
|
||
.. step:: Insert a movie into the database | ||
.. step:: Insert a Movie into the database | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this stay lowercase since it's not a proper noun? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Movie objects are capitalized; I'll add "object" after to make that clear |
||
|
||
Run the following code to create an ``Movie`` object that | ||
stores data about a movie titled ``"Minari"``, including | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using variables in the meta descriptions?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought they didn't render correctly but just checked and they do! So I'll update the descriptions