Skip to content

Correct and copyedit limitations page #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

timgraham
Copy link
Collaborator

@timgraham timgraham commented Feb 4, 2025

I'm still not completely happy with this page, but here are some improvements.

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for docs-django ready!

Name Link
🔨 Latest commit de6d4d7
🔍 Latest deploy log https://app.netlify.com/sites/docs-django/deploys/67bf7a4c6dd56e0008bf36c4
😎 Deploy Preview https://deploy-preview-20--docs-django.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


- ``ATOMIC_REQUESTS``
- ``AUTOCOMMIT``
- ``CONN_HEALTH_CHECKS``
- ``TIME_ZONE``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does? Is it already converting between UTC <--> TZ when retrieved from the DB?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -199,9 +198,6 @@ Django Management Command Limitations

- ``createcachetable``
- ``inspectdb``
- ``optimizemigration``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works (no db interaction).

@@ -199,9 +198,6 @@ Django Management Command Limitations

- ``createcachetable``
- ``inspectdb``
- ``optimizemigration``
- ``sqlflush``
- ``sqlsequencereset``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applicable. This backend does not support fields with sequences (AutoField).

@@ -199,9 +198,6 @@ Django Management Command Limitations

- ``createcachetable``
- ``inspectdb``
- ``optimizemigration``
- ``sqlflush``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not applicable

@timgraham timgraham force-pushed the correct-limitations branch from ecd1427 to c7d07dc Compare February 7, 2025 14:51

.. _django-limitations-async:

Asynchronous Limitations
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- ``ATOMIC_REQUESTS``
- ``AUTOCOMMIT``
- ``CONN_HEALTH_CHECKS``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applicable to this backend. pymongo takes care of this functionality.

Copy link
Collaborator

@Jibola Jibola Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 28 & 29 of this file, we reference the Drivers Feedback Forum. Let's remove that link because we should have the Github Issues & JIRA tickets be our primary proxies for tracking requests and changes.

So we should redirect folks to the Issues & Help section of the docs here instead.

cc: @R-shubham @norareidy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #24.

@timgraham timgraham force-pushed the correct-limitations branch 3 times, most recently from e8eda92 to 4da9095 Compare February 25, 2025 14:20
@timgraham timgraham marked this pull request as ready for review February 25, 2025 14:21
Data Types
~~~~~~~~~~

{+django-odm+} does not have a custom ``Field`` class for the ``BSONRegExp``
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't very important and can be mentioned in the upcoming section only. (Also, "Instead, use the CharField class." doesn't make any sense.)

@timgraham timgraham merged commit de6d4d7 into mongodb:master Feb 26, 2025
5 checks passed
@timgraham timgraham deleted the correct-limitations branch February 26, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants