-
Notifications
You must be signed in to change notification settings - Fork 7
Correct and copyedit limitations page #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-django ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
- ``ATOMIC_REQUESTS`` | ||
- ``AUTOCOMMIT`` | ||
- ``CONN_HEALTH_CHECKS`` | ||
- ``TIME_ZONE`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does? Is it already converting between UTC <--> TZ when retrieved from the DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see how DatabaseOperations.convert_datetimefield_value()
and DatabaseOperations.convert_datetimefield_value()
make use of self.connection.timezone
.
@@ -199,9 +198,6 @@ Django Management Command Limitations | |||
|
|||
- ``createcachetable`` | |||
- ``inspectdb`` | |||
- ``optimizemigration`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works (no db interaction).
@@ -199,9 +198,6 @@ Django Management Command Limitations | |||
|
|||
- ``createcachetable`` | |||
- ``inspectdb`` | |||
- ``optimizemigration`` | |||
- ``sqlflush`` | |||
- ``sqlsequencereset`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable. This backend does not support fields with sequences (AutoField).
@@ -199,9 +198,6 @@ Django Management Command Limitations | |||
|
|||
- ``createcachetable`` | |||
- ``inspectdb`` | |||
- ``optimizemigration`` | |||
- ``sqlflush`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not applicable
ecd1427
to
c7d07dc
Compare
|
||
.. _django-limitations-async: | ||
|
||
Asynchronous Limitations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as per mongodb/django-mongodb-backend#252.
|
||
- ``ATOMIC_REQUESTS`` | ||
- ``AUTOCOMMIT`` | ||
- ``CONN_HEALTH_CHECKS`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable to this backend. pymongo takes care of this functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 28 & 29 of this file, we reference the Drivers Feedback Forum
. Let's remove that link because we should have the Github Issues & JIRA tickets be our primary proxies for tracking requests and changes.
So we should redirect folks to the Issues & Help section of the docs here instead.
cc: @R-shubham @norareidy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #24.
e8eda92
to
4da9095
Compare
Data Types | ||
~~~~~~~~~~ | ||
|
||
{+django-odm+} does not have a custom ``Field`` class for the ``BSONRegExp`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't very important and can be mentioned in the upcoming section only. (Also, "Instead, use the CharField
class." doesn't make any sense.)
4da9095
to
8c7d03a
Compare
8c7d03a
to
de6d4d7
Compare
I'm still not completely happy with this page, but here are some improvements.