-
Notifications
You must be signed in to change notification settings - Fork 7
[Django] CompositePrimaryKey isn't supported #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-django ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this page is reformatted by #27 so I'll add this change to that PR as well
This should be part of a larger commit to update the docs for Django 5.2. (Incidentally, does the commit message need a [Django] prefix? This is, after all, docs-django!) |
@timgraham we often do smaller changes as they come up, and then everything gets release the next time we publish. But per Nora's comment, we'll be closing this in favour of #27 because she's done some extensive reformatting. |
My suggestion is that with multiple versions of the documentation, making all the updates for a given version of Django will make it less likely to forget something (and easier for me to review in one go) and to inadvertently backport something to an older version of the docs where it doesn't apply. Putting this change in the documentation for Django 5.1 doesn't make sense because this feature doesn't exist there. |
For some context: The "master" branch of this repository corresponds to the "upcoming" docs version. So this PR would only add the 5.2 changes to upcoming, not to 5.1. The "v5.1" branch stores the 5.1 docs. For version releases, out usual process would be to merge everything for 5.2 into master; then, once the version is released, we cut a new branch (v5.2) from master and that becomes the new "current". |
To my thinking, documentation corrections and enhancements may also be backported to v5.1 and/or v.5.0 as appropriate, so that's why I'd keep changes for 5.2 separate from other changes that could be backported, like reformatting the limitations table (#27). |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49585
Staging Links
Self-Review Checklist