Skip to content

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented May 21, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49759

Staging Links

  • model-data/indexes
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented May 21, 2025

    Deploy Preview for docs-django ready!

    Name Link
    🔨 Latest commit 3b9bb4c
    🔍 Latest deploy log https://app.netlify.com/projects/docs-django/deploys/682f8e38f5a1f7000808cee7
    😎 Deploy Preview https://deploy-preview-33--docs-django.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM! I would be consistent about using the full Atlas Vector Search product name, as I've been told by a PM that there is sometimes naming confusion from customers.


    .. _django-indexes-vector-search:

    Vector Search Indexes

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    Vector Search Indexes
    Atlas Vector Search Indexes

    S: I've gotten guidance from PMs to include the full product name. Also, to be consistent with the above Atlas Search section.

    Vector Search Indexes
    ~~~~~~~~~~~~~~~~~~~~~

    Vector Search indexes specify the behavior of an Atlas Vector Search, which allows

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    Vector Search indexes specify the behavior of an Atlas Vector Search, which allows
    Atlas Vector Search indexes allow

    S: full product name and edit bc it seems duplicative to say AVS twice

    You can integrate vector search with full-text search queries and AI frameworks to
    support a range of use cases.

    To create a Vector Search index, assign the ``indexes`` option in your model's

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    To create a Vector Search index, assign the ``indexes`` option in your model's
    To create an Atlas Vector Search index, assign the ``indexes`` option in your model's

    S: I would lowercase "vector search" or include full product name

    ``Meta`` class to a ``VectorSearchIndex`` object. Pass the following arguments to the
    ``VectorSearchIndex()`` constructor:

    - ``name``: *(Optional)* The name of your Vector Search index. If you do not

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    - ``name``: *(Optional)* The name of your Vector Search index. If you do not
    - ``name``: *(Optional)* The name of your Atlas Vector Search index. If you do not

    S: lowercase or full product name

    of values that assigns functions to individual vector fields.

    The following example updates the ``Recipe`` model's ``Meta`` class to create
    a Vector Search index named ``"vector_search_idx"`` on the ``ratings`` vector field

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    a Vector Search index named ``"vector_search_idx"`` on the ``ratings`` vector field
    an Atlas Vector Search index named ``"vector_search_idx"`` on the ``ratings`` vector field


    .. tip::

    To learn more about Vector Search queries and indexes, see the following resources:

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    To learn more about Vector Search queries and indexes, see the following resources:
    To learn more about Atlas Vector Search queries and indexes, see the following resources:

    - ``name``: *(Optional)* The name of your Atlas Vector Search index. If you do not
    specify this argument, {+framework+} automatically generates an index name.
    - ``fields``: The fields you want to index. At least one must be a vector
    field, represented by an array of ``FloatField`` or ``IntegerField`` values and an
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    "and an array size" -> "with a size"
    (It would be really helpful to get intersphinx working to https://django-mongodb-backend.readthedocs.io/ so you can have size link to ArrayField.size) If you need help, let me know.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Unfortunately additional changes to the intersphinx links are stalled, I can't configure it myself - the docs platform team does that - and they have some higher priority work at the moment. I added a link to the API docs using the source constant instead

    @aclark4life aclark4life self-requested a review May 22, 2025 11:48
    Copy link
    Collaborator

    @aclark4life aclark4life left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM pending @timgraham comment

    @norareidy norareidy merged commit 794ab48 into mongodb:master May 23, 2025
    5 checks passed
    @norareidy norareidy deleted the DOCSP-49759-vector-search-idx branch May 23, 2025 14:51
    norareidy added a commit that referenced this pull request May 23, 2025
    * DOCSP-49759: Vector search index
    
    * edits
    
    * LM feedback
    
    * fix
    
    * link
    
    * fix link
    
    (cherry picked from commit 794ab48)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants