DOCSP-50489: EmbeddedModelArrayField support #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-django ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rustagir
approved these changes
Jun 5, 2025
source/model-data/models.txt
Outdated
Comment on lines
461
to
464
| You can use an ``EmbeddedModelArrayField`` to represent a MongoDB ``Object`` | ||
| that stores an array of document values. Each document in the array corresponds | ||
| to a {+django-odm+} ``EmbeddedModelField`` value. To create an ``EmbeddedModelArrayField``, | ||
| use the ``EmbeddedModelArrayField()`` class constructor and pass the following arguments: |
There was a problem hiding this comment.
S: there might be confusion between document values and values that are documents
I.e.
- document values of {hello: "world"} -> "world"
- values that are documents - [{hello: "world"}, {goodbye: "sun"}]
Suggested change
| You can use an ``EmbeddedModelArrayField`` to represent a MongoDB ``Object`` | |
| that stores an array of document values. Each document in the array corresponds | |
| to a {+django-odm+} ``EmbeddedModelField`` value. To create an ``EmbeddedModelArrayField``, | |
| use the ``EmbeddedModelArrayField()`` class constructor and pass the following arguments: | |
| You can use an ``EmbeddedModelArrayField`` to represent a MongoDB ``Object`` | |
| that stores an array of documents. Each document in the array corresponds | |
| to a {+django-odm+} ``EmbeddedModelField`` value. To create an ``EmbeddedModelArrayField``, | |
| use the ``EmbeddedModelArrayField()`` class constructor and pass the following arguments: |
aclark4life
reviewed
Jun 6, 2025
source/model-data/models.txt
Outdated
| Use an EmbeddedModelArrayField | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| You can use an ``EmbeddedModelArrayField`` to represent a MongoDB ``Object`` |
There was a problem hiding this comment.
Nit: In the Mongo parlance, isn't an "object" typically called a "document" and if so an EmbeddedModelArrayField could also be called a "document of documents" ?
There was a problem hiding this comment.
Yeah I think document is the better word, changed
aclark4life
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
LGTM!
Just to confirm my understanding,
EmbeddedModelFieldcan contain a singleEmbeddedModelinstance e.g.Awardand as such, it's similar to a one to one relationship in SQL.EmbeddedModelArrayFieldcan contain one or moreEmbeddedModelinstances and as such, it's similar to a one to many relationship in SQL.
norareidy
added a commit
that referenced
this pull request
Jun 6, 2025
* DOCSP-50489: EmbeddedModelArrayField support * edit limitations * edits * RR feedback * AC feedback (cherry picked from commit 8a0692b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-50489
Staging Links
Self-Review Checklist