Skip to content

Conversation

stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Nov 19, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45451

Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit a0cb98b
🔍 Latest deploy log https://app.netlify.com/sites/docs-golang/deploys/673d00d304b7a4000824d98f
😎 Deploy Preview https://deploy-preview-406--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephmarie17 stephmarie17 marked this pull request as ready for review November 19, 2024 20:48
Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one comment

- MongoDB 3.6

* - 1.12 to 1.17
- ⊛ [#8.0-support]_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're missing the footnote for this bullet. Can you add it? You can see it in upcoming here: https://www.mongodb.com/docs/drivers/go/upcoming/compatibility/#ref-8.0-support-id1

Copy link
Collaborator Author

@stephmarie17 stephmarie17 Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks will add! I thought it was commented out in the sharedinclude so I missed it.

@stephmarie17 stephmarie17 merged commit f32f313 into mongodb:v1.17 Nov 19, 2024
4 of 5 checks passed
stephmarie17 added a commit to stephmarie17/docs-golang that referenced this pull request Dec 4, 2024
stephmarie17 added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants