Skip to content

DOCSP-47273: FAQ reorg #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Feb 28, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47273

Staging Links

  • connection/connect
  • connection/mongoclientsettings
  • data-formats/document-data-format-bson
  • data-formats/document-data-format-pojo
  • data-formats/pojo-customization
  • versioning/legacy
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 28, 2025

    Deploy Preview for docs-java ready!

    Name Link
    🔨 Latest commit 9b036b3
    🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/67c5f282a81a58000860f6cb
    😎 Deploy Preview https://deploy-preview-644--docs-java.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Contributor

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A few tweaks:

    @@ -200,3 +206,118 @@ class. Select the tab that corresponds to your preferred class.
    .build();
    MongoClient mongoClient = MongoClients.create(settings);

    ked Questions
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    ked Questions
    Frequently Asked Questions

    @@ -591,4 +591,4 @@ to MongoDB:
    :end-before: end SslSettings
    :language: java
    :emphasize-lines: 3-4
    :dedent:
    :dedent:
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Probably a whitespace thing? Not a big deal if you can't get rid of it.

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yeah I'm not sure why this is showing up as edited


    This exception means you must register a codec for the class since
    none exist.

    Summary
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I've been removing the Summary section on the pages I've touched. I can't see what value they provide.

    .. contents:: On this page
    :local:
    :backlinks: none
    :depth: 1
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I would set this to 2 on all the docs you touch for consistency

    Suggested change
    :depth: 1
    :depth: 2

    @norareidy norareidy marked this pull request as ready for review March 3, 2025 18:24
    @norareidy norareidy merged commit d0e0c8b into mongodb:master Mar 3, 2025
    5 of 6 checks passed
    @norareidy norareidy deleted the DOCSP-47273-faq-reorg branch March 3, 2025 18:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants