Skip to content

Clean up: refs #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 10, 2025
Merged

Clean up: refs #654

merged 5 commits into from
Mar 10, 2025

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Mar 10, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-NNNNN

Staging Links

  • connection/connect
  • connection/connection-options
  • connection/mongoclientsettings
  • crud/builders/aggregates
  • crud/builders/filters
  • crud/builders/indexes
  • crud/builders/projections
  • crud/builders/sort
  • crud/collations
  • crud/compound-operations
  • crud/gridfs
  • crud/query-document
  • crud/read-operations/geo
  • crud/read-operations/limit
  • crud/read-operations/retrieve
  • crud/read-operations/sort
  • crud/read-operations/text
  • crud/write-operations/embedded-arrays
  • crud/write-operations/insert
  • crud/write-operations/modify
  • crud/write-operations/upsert
  • data-formats/codecs
  • data-formats/document-data-format-bson
  • data-formats/document-data-format-extended-json
  • data-formats/documents
  • data-formats/pojo-customization
  • data-formats/time-series
  • get-started/connect-to-mongodb
  • index
  • logging-monitoring/logging
  • logging-monitoring/monitoring

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @rachel-mack rachel-mack marked this pull request as ready for review March 10, 2025 14:41
    @netlify Netlify
    Copy link

    netlify bot commented Mar 10, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-java ready!

    Name Link
    🔨 Latest commit f1d821c
    🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/67cf31eb8a662000080c0282
    😎 Deploy Preview https://deploy-preview-654--docs-java.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @rachel-mack rachel-mack changed the title TOC Clean up: Fundamentals Clean up: refs Mar 10, 2025
    mongoKart
    mongoKart approved these changes Mar 10, 2025
    View reviewed changes
    Copy link
    Contributor

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ a couple small things

    source/usage-examples/updateOne.txt
    We use the ``Updates`` builder, a factory class that contains static
    helper methods, to construct the update document. While you can pass an update
    document instead of using the builder, the builder provides type checking and
    simplified syntax. For more information about the ``Updates`` builder, see our
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    SG discourages 'our' where possible. Maybe just say 'the guide'

    Applies throughout

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This page is getting deleted, so I'm not going to bother with this.

    @rachel-mack rachel-mack merged commit a5e8390 into mongodb:master Mar 10, 2025
    6 checks passed
    @rachel-mack rachel-mack deleted the build-error branch March 10, 2025 18:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @mongoKart mongoKart mongoKart approved these changes

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @rachel-mack @mongoKart