Skip to content

DOCSP-51408-connection-troubleshooting #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Jul 8, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51325

Staging Links

  • connect/connection-pools
  • connect/connection-troubleshooting
  • connect
  • connect/connection-options
  • connect/connection-targets
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Jul 8, 2025

    Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit c39c049
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/686e90969fcf98000889dea7
    😎 Deploy Preview https://deploy-preview-109--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 8, 2025

    🔄 Deploy Preview for docs-kotlin-sync processing

    Item Details
    🔨 Latest Commit 9b3436c5b794fdfbd5a3eab16c01a61af87a9938
    😎 Deploy Preview https://deploy-preview-109--docs-kotlin-sync.netlify.app
    🔍 Build Logs View Logs

    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Small comments, LGTM!

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: I would add a .. TODO comment on the page just to keep things clear!


    .. replacement:: authentication-guide-reference

    To learn more about specifying authentication mechanisms, see the :ref`kotlin-sync-auth`
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    To learn more about specifying authentication mechanisms, see the :ref`kotlin-sync-auth`
    To learn more about specifying authentication mechanisms, see the :ref`<kotlin-sync-auth>`

    I: Broken ref, this should hopefully fix.


    You can also specify the ``serverSelectionTimeoutMS`` connection option
    to adjust the amount of time in which the driver must select a server. To
    learn more, see the :ref:`kotlin-sync-connection-options` guide.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I: Make sure the Connection Options page is clickable as a landing page in the TOC.

    .. meta::
    :keywords: code example, disconnected, deployment

    .. sharedinclude:: dbx/connection-troubleshooting.rst
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: The first line of the Server Connection Errors section reads, "When an issue occurs when you attempt to connect to a server, the Kotlin Sync driver returns an error message." I would make a PR to change the first word of this sentence to "if" ! Small change, but it would be nice to not include so much certainty that there will be an error.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'll send this PR out for tech review but make a new ticket/PR to reflect this work, as it's in a different repo!

    @shuangela shuangela requested review from a team and katcharov and removed request for a team July 9, 2025 16:02
    .. _kotlin-sync-connection-troubleshooting:

    ==========================
    Connection Troubleshooting
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Note for reviewer: this page is almost identical to https://www.mongodb.com/docs/drivers/java/sync/current/connection/connection-troubleshooting/ except for two code examples that I've commented on below.

    corresponds to the authentication mechanism. The following code shows the builder
    method for the ``SCRAM-SHA-256`` authentication mechanism:

    .. code-block:: kotlin
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This code is kotlin specific code that differs from the java sync version of this page.


    .. replacement:: authsource-param-code-block

    .. code-block:: kotlin
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is Kotlin specific code that differs from the Java version of this page

    Copy link

    @katcharov katcharov left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @shuangela shuangela merged commit 3bfbf9c into mongodb:comp-cov Jul 15, 2025
    5 of 6 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants