Skip to content

Conversation

mcmorisi
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41133
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41133-specify-query/read/specify-a-query/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jul 16, 2024

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 74a9f71

Comment on lines +256 to +257
To learn more about retrieving documents with the {+driver-short+}, see
:ref:`kotlin-sync-retrieve`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: The retrieve page here is currently also in review. This PR should be merged in after the retrieve page is merged.

Link to Retrieve page PR

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! LGTM w/ a question and suggestion


- ``$text``, which performs a text search on the documents
- ``$regex``, which returns documents that match a specified regular expression
- ``$mod``, which performs a modulo operation on the value of a field and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think it could be helpful to link to modulo here for those who don't know what it is

Suggested change
- ``$mod``, which performs a modulo operation on the value of a field and
- ``$mod``, which performs a :wikipedia:`modulo </Modulo>` operation on the value of a field and

Comment on lines 68 to 69
The following example specifies a query filter as a parameter to the ``find()``
method. The code returns all documents with a ``color`` field value of ``"yellow"``:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our guidance isn't 100% clear on what "introducing" means, but the style guide on colons says: "If another sentence intervenes between the introduction and the thing being introduced, use a period instead of a colon." I think that might apply to these examples? Since we say "The following example..." in the first sentence, but then have a clarifying sentence in between.
I can see a case where both sentences are introduction sentences though, so will differ to your judgement on whether or not we change these.

Applies to most sections

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your interpretation of the style guide here. Can change these to periods.

@rozza rozza requested review from a team and rozza and removed request for a team July 16, 2024 16:01
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmorisi mcmorisi merged commit ffd5d1f into mongodb:master Jul 18, 2024
@mcmorisi mcmorisi deleted the DOCSP-41133-specify-query branch July 18, 2024 13:20
mcmorisi added a commit that referenced this pull request Jul 18, 2024
(cherry picked from commit ffd5d1f)
mcmorisi added a commit that referenced this pull request Jul 18, 2024
(cherry picked from commit ffd5d1f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants