Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jul 16, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41120
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin-sync/DOCSP-41120-cxn/connect/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jul 16, 2024

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f404597

@rustagir rustagir marked this pull request as ready for review July 17, 2024 16:13
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, mostly about adding a little more introduction to sections and examples. Good work!

@rustagir rustagir requested a review from mcmorisi July 17, 2024 17:06
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits, thanks for the quick follow!

@rustagir rustagir requested review from a team, jyemin and rozza and removed request for a team and jyemin July 17, 2024 17:14
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir merged commit bd33ef7 into mongodb:master Jul 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants