-
Notifications
You must be signed in to change notification settings - Fork 10
DOCSP-41141: Indexes #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for docs-kotlin-sync pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small things, but I'd like to take another look!
source/indexes.txt
Outdated
Atlas Search Index | ||
------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: This section could be called Atlas Search Index Management
source/indexes.txt
Outdated
Atlas Search Index | ||
------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: what is the rationale to have this section in this location in the TOC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The honest answer is that I just grabbed the format from Pymongo's equivalent. I reached out to Jordan (who wrote the Pymongo page) and he mentioned his placement was based on the Java page.
Do you have strong feelings about shifting the section up or down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont have strong feelings, but i would suggest moving the section to the end of the list of index types as this is a separate index category with different methods
source/indexes.txt
Outdated
Update Search Indexes | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The following example updates an existing Atlas search index: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: describe the update
The following example updates an existing Atlas search index: | |
The following example updates an existing Atlas search index to ...: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
(cherry picked from commit 8920746)
(cherry picked from commit 8920746)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41141
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41141-indexes/indexes/
Self-Review Checklist