Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jul 17, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41141
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41141-indexes/indexes/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jul 17, 2024

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b12740d

@rustagir rustagir self-requested a review July 17, 2024 16:08
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things, but I'd like to take another look!

Comment on lines 102 to 103
Atlas Search Index
------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: This section could be called Atlas Search Index Management

Comment on lines 102 to 103
Atlas Search Index
------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: what is the rationale to have this section in this location in the TOC?

Copy link
Collaborator Author

@mcmorisi mcmorisi Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The honest answer is that I just grabbed the format from Pymongo's equivalent. I reached out to Jordan (who wrote the Pymongo page) and he mentioned his placement was based on the Java page.

Do you have strong feelings about shifting the section up or down?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have strong feelings, but i would suggest moving the section to the end of the list of index types as this is a separate index category with different methods

Update Search Indexes
~~~~~~~~~~~~~~~~~~~~~

The following example updates an existing Atlas search index:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: describe the update

Suggested change
The following example updates an existing Atlas search index:
The following example updates an existing Atlas search index to ...:

@mcmorisi mcmorisi requested a review from rustagir July 17, 2024 18:41
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcmorisi mcmorisi merged commit 8920746 into mongodb:master Jul 19, 2024
1 of 2 checks passed
@mcmorisi mcmorisi deleted the DOCSP-41141-indexes branch July 19, 2024 14:36
mcmorisi added a commit that referenced this pull request Jul 19, 2024
(cherry picked from commit 8920746)
mcmorisi added a commit that referenced this pull request Jul 19, 2024
(cherry picked from commit 8920746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants