Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jul 22, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41144
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41144-atlas-search-index/indexes/atlas-search-index

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jul 22, 2024

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8dc5433

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions and a question/clarification!

@mcmorisi mcmorisi requested a review from jordan-smith721 July 23, 2024 13:25
Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmorisi mcmorisi requested review from a team and rozza and removed request for a team July 23, 2024 14:58
@mcmorisi mcmorisi merged commit 7ce8c73 into mongodb:master Jul 25, 2024
1 of 2 checks passed
@mcmorisi mcmorisi deleted the DOCSP-41144-atlas-search-index branch July 25, 2024 13:17
mcmorisi added a commit that referenced this pull request Jul 25, 2024
mcmorisi added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants