Skip to content

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Jul 23, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41125
Staging - https://preview-mongodblindseymoore.gatsbyjs.io/kotlin-sync/DOCSP-41125-stable-api/connect/stable-api/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for docs-kotlin-sync ready!

Name Link
🔨 Latest commit 043ca48
🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin-sync/deploys/66a9471522e8000008a717b7
😎 Deploy Preview https://deploy-preview-18--docs-kotlin-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just a few nits to address.

@lindseymoore lindseymoore requested a review from mcmorisi July 29, 2024 19:38
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last little thing, sending it back for another pass just to verify that links still work after you make the change, but the copy looks good to me!

snooty.toml Outdated
kotlin-docs = "https://kotlinlang.org"
core-api = "https://mongodb.github.io/mongo-java-driver/{+version-number+}/apidocs/mongodb-driver-core/com/mongodb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break existing links that appear in the Kotlin Sync repo. You should use the following value for core-api and update any links you have to make sure they work. You can probably just duplicate the snooty.toml file from the current main branch of the repo

Suggested change
core-api = "https://mongodb.github.io/mongo-java-driver/{+version-number+}/apidocs/mongodb-driver-core/com/mongodb"
core-api = "{+java-api+}/apidocs/mongodb-driver-core/"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thanks for catching this! Updated

@lindseymoore lindseymoore requested a review from mcmorisi July 29, 2024 21:14
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@lindseymoore lindseymoore merged commit 5a83299 into mongodb:master Jul 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants