-
Notifications
You must be signed in to change notification settings - Fork 10
DOCSP-41129: update docs #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for docs-kotlin-sync pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! A few open questions and some small suggestions.
source/write/update.txt
Outdated
to. | ||
|
||
* - ``hint()`` | ||
- | Gets or sets the index to scan for documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: The intro to this section refers to this collection of methods as "setter methods" but this method in particular mentions getting OR setting. Does it make sense to discuss the get functionality of this method within the context of this table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, copypasta error. This is only a set
method in this driver, getHint()
would be the getter. Will review the descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41129
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kotlin-sync/DOCSP-41129-update/write/update/
Self-Review Checklist