DOCSP-41152: Time Series #23
Conversation
👷 Deploy request for docs-kotlin-sync pending review.Visit the deploys page to approve it
|
|
|
||
| - The name of the new collection to create | ||
|
|
||
| - A `CreateCollectionOptions <{+core-api+}/com/mongodb/client/model/CreateCollectionOptions.html>`__ |
There was a problem hiding this comment.
S: The API docs state that CreateCollectionOptions is a class, change "object" to "class"
There was a problem hiding this comment.
In Java, an object refers to an individual instantiation of a class (i.e. a class is the "template" and the object is the thing made from the template). In this case, I think it makes sense to leave this as "object".
source/data-formats/time-series.txt
Outdated
| - The name of the new collection to create | ||
|
|
||
| - A `CreateCollectionOptions <{+core-api+}/com/mongodb/client/model/CreateCollectionOptions.html>`__ | ||
| object containing the `TimeSeriesOptions <{+core-api+}/com/mongodb/client/model/TimeSeriesOptions.html>`__ object |
There was a problem hiding this comment.
Q: Containing seems like a weird word choice here because in the example, timesseriesoptions is chained to createcollectionoptions. If it was containing, i'd expect TimeSeriesOptions to be a parameter.
S: Clarify that you chain TimeSeriesOptions to CreateConnectionOptions to create a timeseries collection
| val results = database.listCollections() | ||
|
|
||
| results.forEach { result -> | ||
| println(result.toJson(JsonWriterSettings.builder().indent(true).build())) |
There was a problem hiding this comment.
Nit: You could create the settings just once and reuse
(cherry picked from commit c8d9955)
(cherry picked from commit c8d9955)
Adapted from the C++ draft and Kotlin Coroutine versions of this page.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41152
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41152-time-series/data-formats/time-series/
Self-Review Checklist