DOCSP-41161: Builders landing page #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kotlin-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
suggested changes
Aug 1, 2024
source/builders.txt
Outdated
Comment on lines
43
to
44
| This section describes three methods of fetching the ``email`` field values of documents | ||
| in the ``users`` collection that meet the following criteria: |
There was a problem hiding this comment.
Suggested change
| This section describes three methods of fetching the ``email`` field values of documents | |
| in the ``users`` collection that meet the following criteria: | |
| This section provides three equivalent ways to fetch the ``email`` field values of documents | |
| in the ``users`` collection that meet the following criteria: |
source/includes/builders/builders.kt
Outdated
| // start-find | ||
| val filter = Document("gender", "female").append("age", Document("\$gt", 29)) | ||
| val projection = Document("_id", 0).append("email", 1) | ||
| val results = collection.find<Result>(filter).projection(projection) |
There was a problem hiding this comment.
Suggested change
| val results = collection.find<Result>(filter).projection(projection) | |
| val results = collection.find<Email>(filter).projection(projection) |
rustagir
approved these changes
Aug 1, 2024
rozza
reviewed
Aug 7, 2024
source/builders.txt
Outdated
| Overview | ||
| -------- | ||
|
|
||
| This page describes how to implement the builders pattern in your code and describes |
There was a problem hiding this comment.
Nit: This seems a little verbose. In short its about using builders to help build operations in a less verbose way than using Documents.
There was a problem hiding this comment.
For further clarification, do you think the entire Overview section is too verbose?
source/builders.txt
Outdated
| .. _kotlin-sync-builders: | ||
|
|
||
| =============================== | ||
| Implement Builders Code Pattern |
There was a problem hiding this comment.
Not sure this title makes sense - users aren't implementing builders we are consuming them.
rozza
reviewed
Aug 13, 2024
source/builders.txt
Outdated
| Overview | ||
| -------- | ||
|
|
||
| This page describes how to implement the builders pattern in your code and describes |
rozza
requested changes
Aug 14, 2024
source/builders.txt
Outdated
| Overview | ||
| -------- | ||
|
|
||
| This page describes how to the various available builders in your code and describes |
There was a problem hiding this comment.
Suggested change
| This page describes how to the various available builders in your code and describes | |
| This page describes how to used the various available builders in your code and describes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from the coroutine builders page, did some trimming and updating.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41161
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41161-builders/builders/
Self-Review Checklist