Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Aug 2, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41145
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41145-aggregation/aggregation/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • [] Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Aug 2, 2024

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 879d49a

Comment on lines +209 to +210
- `aggregate() <{+api+}/com.mongodb.kotlin.client/-mongo-collection/aggregate.html>`__
- `AggregateIterable <{+api+}/com.mongodb.kotlin.client/-aggregate-iterable/index.html>`__
Copy link
Collaborator Author

@mcmorisi mcmorisi Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: these links are broken at the moment.

Rea has a change that has yet to be merged that changes the {+api+} source constant. This will work once it's merged.

@rustagir rustagir self-requested a review August 2, 2024 20:21
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things

@mcmorisi mcmorisi requested a review from rustagir August 5, 2024 14:38
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcmorisi mcmorisi requested review from rustagir, a team and vbabanin and removed request for a team August 5, 2024 19:29
@rustagir
Copy link
Contributor

rustagir commented Aug 6, 2024

@mcmorisi did you want me to review again? i approved a few days ago

@rustagir rustagir removed their request for review August 6, 2024 18:06
@rustagir rustagir mentioned this pull request Aug 7, 2024
5 tasks
Copy link
Member

@vbabanin vbabanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmorisi mcmorisi merged commit 88f71b9 into mongodb:master Aug 9, 2024
1 of 2 checks passed
@mcmorisi mcmorisi deleted the DOCSP-41145-aggregation branch August 9, 2024 13:09
mcmorisi added a commit that referenced this pull request Aug 9, 2024
mcmorisi added a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants