Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Aug 6, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41140
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41140-change-streams/read/change-streams/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for docs-kotlin-sync ready!

Name Link
🔨 Latest commit 587b2d5
🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin-sync/deploys/66bcd1be08bf0b0008120b8a
😎 Deploy Preview https://deploy-preview-31--docs-kotlin-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +275 to +278
- `MongoClient.watch() <{+api+}/com.mongodb.kotlin.client/-mongo-client/watch.html>`__
- `MongoDatabase.watch() <{+api+}/com.mongodb.kotlin.client/-mongo-database/watch.html>`__
- `MongoCollection.watch() <{+api+}/com.mongodb.kotlin.client/-mongo-collection/watch.html>`__
- `ChangeStreamIterable <{+api+}/com.mongodb.kotlin.client/-change-stream-iterable/index.html>`__
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: these links are broken at the moment.

Rea has a change that has yet to be merged that changes the {+api+} source constant. These will work once it's merged.

@rustagir rustagir self-requested a review August 6, 2024 14:10
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few things, good work!

@mcmorisi mcmorisi requested a review from rustagir August 6, 2024 16:13
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with some non blocking comments, I can take another look if needed

@mcmorisi mcmorisi requested review from a team and jyemin and removed request for a team August 6, 2024 17:44
Copy link

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure how to review this. Is all the prose brand new or is it a copy of existing documentation for either the Java sync driver or the Kotlin coroutine driver, or some combo of the two?

@mcmorisi mcmorisi requested a review from jyemin August 9, 2024 18:32
@mcmorisi mcmorisi requested a review from jyemin August 14, 2024 14:05
@mcmorisi mcmorisi requested a review from jyemin August 14, 2024 15:48
Copy link

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmorisi mcmorisi merged commit 7f97934 into mongodb:master Aug 15, 2024
5 of 6 checks passed
@mcmorisi mcmorisi deleted the DOCSP-41140-change-streams branch August 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants