Skip to content

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Aug 15, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41116
Staging - https://preview-mongodblindseymoore.gatsbyjs.io/kotlin-sync/DOCSP-41116/whats-new/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for docs-kotlin-sync ready!

Name Link
🔨 Latest commit 7f1e417
🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin-sync/deploys/66bfb4a3b6f5fe0008e4b5a8
😎 Deploy Preview https://deploy-preview-38--docs-kotlin-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 117 to 118
:ref:`kotlin-polymorphic` section of the Kotlin Serialization guide.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Support for polymorphic serialization. To learn more, see the
:ref:`kotlin-polymorphic` section of the Kotlin Serialization guide.
- Support for polymorphic serialization.

Don't see a ticket for this page. Are we planning on making a serialization page, or should I delete this sentence?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a ticket for a serialization page, i do think it is important

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment this out as a TODO then?

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things! lmk if you need any clarification

Comment on lines 117 to 118
:ref:`kotlin-polymorphic` section of the Kotlin Serialization guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a ticket for a serialization page, i do think it is important

Comment on lines 117 to 118
:ref:`kotlin-polymorphic` section of the Kotlin Serialization guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 117 to 118
:ref:`kotlin-polymorphic` section of the Kotlin Serialization guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment this out as a TODO then?

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one comment!

@lindseymoore lindseymoore merged commit d45f795 into mongodb:master Aug 16, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants