-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-46708 MongoClient.watch() API 404 #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-kotlin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -95,7 +95,7 @@ documentation: | |||
|
|||
- `MongoCollection.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-collection/watch.html>`__ | |||
- `MongoDatabase.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-database/watch.html>`__ | |||
- `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-client/watch.html>`__ | |||
- `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-client/index.html#1590990028%2FFunctions%2F-1409914714>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: I think the problem here is to fix the class name
- `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-client/index.html#1590990028%2FFunctions%2F-1409914714>`__ | |
- `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-cluster/watch.html>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustagir Think it's confusing to link to MongoCluster
if the method call is for a MongoClient
instance. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, will use the MongoCluster
link for maintenance reasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving as I think you can resolve without another look
* DOCSP-46708 MongoClient.watch() API 404 * change to direct link to mongoclient.watch * change link to originating MongoCluster one (cherry picked from commit a584b47)
* DOCSP-46708 MongoClient.watch() API 404 * change to direct link to mongoclient.watch * change link to originating MongoCluster one (cherry picked from commit a584b47)
* DOCSP-46708 MongoClient.watch() API 404 * change to direct link to mongoclient.watch * change link to originating MongoCluster one (cherry picked from commit a584b47) Co-authored-by: lindseymoore <[email protected]>
* DOCSP-46708 MongoClient.watch() API 404 * change to direct link to mongoclient.watch * change link to originating MongoCluster one (cherry picked from commit a584b47) Co-authored-by: lindseymoore <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46708
Staging Links
Link in this "Example" section: https://deploy-preview-192--docs-kotlin.netlify.app/fundamentals/crud/read-operations/change-streams/#example
Self-Review Checklist