Skip to content

DOCSP-46708 MongoClient.watch() API 404 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Feb 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46708

Staging Links

  • fundamentals/crud/read-operations/change-streams
  • Link in this "Example" section: https://deploy-preview-192--docs-kotlin.netlify.app/fundamentals/crud/read-operations/change-streams/#example

    Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 3, 2025

    Deploy Preview for docs-kotlin ready!

    Name Link
    🔨 Latest commit 780dcd1
    🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin/deploys/67a114c640846e00085626b9
    😎 Deploy Preview https://deploy-preview-192--docs-kotlin.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @@ -95,7 +95,7 @@ documentation:

    - `MongoCollection.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-collection/watch.html>`__
    - `MongoDatabase.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-database/watch.html>`__
    - `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-client/watch.html>`__
    - `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-client/index.html#1590990028%2FFunctions%2F-1409914714>`__
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I: I think the problem here is to fix the class name

    Suggested change
    - `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-client/index.html#1590990028%2FFunctions%2F-1409914714>`__
    - `MongoClient.watch() <{+api+}/apidocs/mongodb-driver-kotlin-coroutine/mongodb-driver-kotlin-coroutine/com.mongodb.kotlin.client.coroutine/-mongo-cluster/watch.html>`__

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @rustagir Think it's confusing to link to MongoCluster if the method call is for a MongoClient instance. What do you think?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    After discussion, will use the MongoCluster link for maintenance reasons

    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    approving as I think you can resolve without another look

    @lindseymoore lindseymoore merged commit a584b47 into mongodb:master Feb 3, 2025
    10 checks passed
    github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
    * DOCSP-46708 MongoClient.watch() API 404
    
    * change to direct link to mongoclient.watch
    
    * change link to originating MongoCluster one
    
    (cherry picked from commit a584b47)
    github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
    * DOCSP-46708 MongoClient.watch() API 404
    
    * change to direct link to mongoclient.watch
    
    * change link to originating MongoCluster one
    
    (cherry picked from commit a584b47)
    lindseymoore added a commit that referenced this pull request Feb 3, 2025
    * DOCSP-46708 MongoClient.watch() API 404
    
    * change to direct link to mongoclient.watch
    
    * change link to originating MongoCluster one
    
    (cherry picked from commit a584b47)
    
    Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 3, 2025
    * DOCSP-46708 MongoClient.watch() API 404
    
    * change to direct link to mongoclient.watch
    
    * change link to originating MongoCluster one
    
    (cherry picked from commit a584b47)
    
    Co-authored-by: lindseymoore <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants