DOCSP-47980-log-storage-size #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-mongodb-shell ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kennethdyer
approved these changes
Mar 3, 2025
gagik
approved these changes
Mar 5, 2025
source/logs/retention/size.txt
Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| To instruct |mdb-shell| to not delete logs based on storage size, set | ||
| ``logRetentionGB`` to ``Infinity``. You can perform this action through |
There was a problem hiding this comment.
I think it's good to leave it like this
just fyi: undefined (the default, unset value) would also do this.
it'd be more performant with undefined at the moment but this is something we can quickly fix to work the same with Infinity so I don't mind leaving it here.
cc: @addaleax @alenakhineika
There was a problem hiding this comment.
created mongodb-js/devtools-shared#515 to address this
There was a problem hiding this comment.
Got it - Thanks for the context and for filing the ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Customize log storage size.
STAGING
JIRA
https://jira.mongodb.org/browse/DOCSP-47980
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?