DOCSP-42971-vscode-nested-components #93
Conversation
✅ Deploy Preview for docs-mongodb-vscode ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@jmd-mongo would you mind taking a look at this PR? Thanks! |
There was a problem hiding this comment.
Thanks for this updated, @gmiller-mdb! I've left a suggestion for your consideration.
Thanks,
Joe
| You can only use SRV connection strings to connect to | ||
| deployments running MongoDB 3.6 and later. | ||
| You can only use SRV connection strings to connect to |
There was a problem hiding this comment.
[suggestion]
I think we can consider removing this line entirely since this covers all supported versions.
There was a problem hiding this comment.
@jmd-mongo this look good?
There was a problem hiding this comment.
Thank you for these updates, @gmiller-mdb! This one LGTM at this point.
Thanks,
Joe
| .. example:: | ||
| For example: | ||
| If the following is your SRV connection string for |
There was a problem hiding this comment.
I believe the indents here are also causing build errors!
| @@ -1,4 +1,3 @@ | |||
| .. important:: | |||
|
|
|||
| To launch your selected MongoDB shell, you must: | |||
There was a problem hiding this comment.
[nit] The indent(s) here are causing a build error!
| connection. | ||
| Removing your current active connection also closes that | ||
| connection. | ||
|
|
There was a problem hiding this comment.
I can't comment on the applicable lines, but on this file and on settings.txt, build errors are being caused by the |vsce-short| substitution. Can you check to make sure this variable exists in snooty.toml? If not, replace the variable with |vsce| !
There was a problem hiding this comment.
@ajhuh-mdb Tried to fix the build errors seems like the new command is 'vscode-short'. Hopefully that works!
| .. important:: | ||
|
|
||
| To launch your selected MongoDB shell, you must: | ||
| To launch your selected MongoDB shell, you must: |
There was a problem hiding this comment.
[nit] since we removed the important:: admonition, we want to make sure the the text here has no indentations & is flushed to the margin of the page!
| To launch your selected MongoDB shell, you must: | |
| To launch your selected MongoDB shell, you must: |
source/commands.txt
Outdated
| ===================== | ||
| |vsce-short| Commands | ||
| |vscode-short| Commands | ||
| ===================== |
There was a problem hiding this comment.
[nit] since we changed the variable here, we want to make sure the header syntax has enough =s to cover the text. a new build error is popping up bc of this!
DESCRIPTION
Fixed admonitions in tables and examples in tables for VScode. Removed one important admonition.
STAGING
https://deploy-preview-93--docs-mongodb-vscode.netlify.app/commands/
https://deploy-preview-93--docs-mongodb-vscode.netlify.app/connect/
https://deploy-preview-93--docs-mongodb-vscode.netlify.app/settings/
JIRA
https://jira.mongodb.org/browse/DOCSP-42971
BUILD LOG
https://app.netlify.com/sites/docs-mongodb-vscode/deploys/66e89b35f8c50c00081d9922
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?