Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Mar 21, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48562

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit 21d39f3
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/67e1635926388d0008bf1b4a
😎 Deploy Preview https://deploy-preview-117--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir requested a review from jamis March 21, 2025 17:49
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + 2 small things

# Allows duplicate indexes to be declared and sent
# to the server. The server then validates the indexes and raises an
# exception if duplicate indexes are detected. When false, indexes
# are validated on the client which can lead to some indexes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# are validated on the client which can lead to some indexes
# are validated on the client, which can lead to some indexes

Comment on lines 31 to 32
the server. This allows you to view an error if a duplicate index is
declared. To learn more, see the :ref:`mongoid-config-options-all`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s: 'view an error' is a little vague as to what actually happens

Suggested change
the server. This allows you to view an error if a duplicate index is
declared. To learn more, see the :ref:`mongoid-config-options-all`
the server. If a duplicate index is declared, the server raises an error.
To learn more, see the :ref:`mongoid-config-options-all`

@rustagir rustagir merged commit 1392457 into mongodb:master Mar 24, 2025
6 checks passed
rustagir added a commit that referenced this pull request Mar 24, 2025
* DOCSP-48562: dupe index config

* MW suggestion

(cherry picked from commit 1392457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants