-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-48562: dupe index config #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48562: dupe index config #117
Conversation
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + 2 small things
# Allows duplicate indexes to be declared and sent | ||
# to the server. The server then validates the indexes and raises an | ||
# exception if duplicate indexes are detected. When false, indexes | ||
# are validated on the client which can lead to some indexes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# are validated on the client which can lead to some indexes | |
# are validated on the client, which can lead to some indexes |
source/whats-new.txt
Outdated
the server. This allows you to view an error if a duplicate index is | ||
declared. To learn more, see the :ref:`mongoid-config-options-all` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s: 'view an error' is a little vague as to what actually happens
the server. This allows you to view an error if a duplicate index is | |
declared. To learn more, see the :ref:`mongoid-config-options-all` | |
the server. If a duplicate index is declared, the server raises an error. | |
To learn more, see the :ref:`mongoid-config-options-all` |
* DOCSP-48562: dupe index config * MW suggestion (cherry picked from commit 1392457)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48562
Staging Links
Self-Review Checklist