-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-48887: docs+ atlas search tutorial #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48887: docs+ atlas search tutorial #129
Conversation
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some suggestions
To successfully demonstrate the search functionality later in | ||
the tutorial, insert sample documents that contain some overlapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: this wording seems a little clearer to me since the tutorial is demostrating:
To successfully demonstrate the search functionality later in | |
the tutorial, insert sample documents that contain some overlapping | |
To achieve the search functionality demonstrated later in | |
the tutorial, insert sample documents that contain some overlapping |
|
||
git clone https://github.com/mongodb-developer/mongodb-atlas-with-ruby-on-rails-example.git | ||
|
||
Then, set up the following components: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: since each list item is more of an action rather than a component:
Then, set up the following components: | |
Then, perform the following setup actions: |
First, update the ``Idea`` model to handle queries to our | ||
database by defining the ``search`` method in the model. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
First, update the ``Idea`` model to handle queries to our | |
database by defining the ``search`` method in the model. The | |
First, update the ``Idea`` model to handle database queries | |
by defining the ``search`` method in the model. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reworded
In this step, you create a ``SearchesController`` to handle Atlas Search | ||
requests and display results. | ||
|
||
Run the following command to generate the ``SearchesController`` | ||
and the ``display_results`` view file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I don't think you need the step intro sentence
In this step, you create a ``SearchesController`` to handle Atlas Search | |
requests and display results. | |
Run the following command to generate the ``SearchesController`` | |
and the ``display_results`` view file: | |
Run the following command to generate the ``SearchesController`` | |
and the ``display_results`` view file, which handle Atlas Search requests and display the results: |
|
||
.. step:: Start your application and run Search queries. | ||
|
||
Run the following command to start your application: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S:
Run the following command to start your application: | |
In your project directory, run the following command to start your application: |
* DOCSP-48887: docs+ atlas search tutorial * small fix * vale * tip * NR PR fixes 1 * wip (cherry picked from commit 64ddba9)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48887
Staging Links
Self-Review Checklist