Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 27, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42732
Staging - https://deploy-preview-47--docs-mongoid.netlify.app/quick-start-sinatra/download-and-install/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit a0f2f91
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/66fad83043b11f0008cfb21e
😎 Deploy Preview https://deploy-preview-47--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir changed the title DOCSP-42732: qs download DOCSP-42732: qs download (sinatra) Sep 27, 2024
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small issues and suggestions, but LGTM otherwise

Ruby. By using {+odm+}, you can easily interact with your data and
create flexible data models.

Sinatra is a Domain Specific Language (DSL) for creating web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: Doesn't look like this needs capitalization

Suggested change
Sinatra is a Domain Specific Language (DSL) for creating web
Sinatra is a domain-specific language (DSL) for creating web

Comment on lines 20 to 21
- `Ruby <https://www.ruby-lang.org/en/documentation/installation/>`__
- `RubyGems package manager <https://rubygems.org/pages/download>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: Parallel punctuation

Suggested change
- `Ruby <https://www.ruby-lang.org/en/documentation/installation/>`__
- `RubyGems package manager <https://rubygems.org/pages/download>`__
- `Ruby. <https://www.ruby-lang.org/en/documentation/installation/>`__
- `RubyGems package manager. <https://rubygems.org/pages/download>`__


gem install mongoid

In {+language+}, packages are called **gems**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Move this line to immediately before "Run the following command..." a few lines up

- A terminal app and shell. For MacOS users, use Terminal or a similar app.
For Windows users, use PowerShell.

Download and Install the Mongoid Gem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: You could use the {+odm+} constant here (I know that makes the heading dashes weird

Ensure that the version of {+odm+} you install is compatible with the
version of {+language+} installed on your operating system. To
learn which versions are compatible, see the
:ref:`mongoid-compatibility` page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Could add a second source constant for lowercase mongoid, since it's used several times on this page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's used in anchors, I am good to leave it as written


.. step:: Install gems

Run the following command to install the list of gems into your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S:

Suggested change
Run the following command to install the list of gems into your
Run the following command to install the gems into your

bundle install

When the command runs successfully, the output in your
shell contains a ``Bundle complete!`` message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is "Bundle complete!" just part of the message? If so, this makes sense; otherwise, you could say "displays a...message"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message has info about the number of gems installed and some other info, which is why I phrased it this way. I think pasting the full message might be confusing as the number of installed packages could differ between users.

@rustagir rustagir merged commit 2848614 into mongodb:standardized Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants