Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Oct 14, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43961
Staging - https://deploy-preview-52--docs-mongoid.netlify.app/quick-start-rails/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit 7ee7a35
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/670fc6ba4733780008f93667
😎 Deploy Preview https://deploy-preview-52--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on a long PR!

Ruby. By using {+odm+}, you can easily interact with your data and
create flexible data models.

Ruby on Rails, or Rails, is a web application framework for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: for clarity

Suggested change
Ruby on Rails, or Rails, is a web application framework for
Ruby on Rails, also known as Rails, is a web application framework for

alternatively, add it in the first paragraph when you intro the term:

This guide shows you how to use {+odm+} in a new Ruby on Rails 7 (Rails) web

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: You could just say "Rails" or "Ruby on Rails" here, since you've already introduced both terms

Comment on lines 40 to 41
modeled and displayed. {+odm+} replaces Rails' default
``ActiveRecord`` adapter for data modeling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: for clarity, and to avoid the question of whether to add another S after the apostrophe

Suggested change
modeled and displayed. {+odm+} replaces Rails' default
``ActiveRecord`` adapter for data modeling.
modeled and displayed. {+odm+} replaces the default
``ActiveRecord`` adapter for data modeling in Rails.

If you prefer to use Sinatra as your web framework, see the
:ref:`mongoid-quick-start-sinatra` guide.

MongoDB Atlas is a fully managed cloud database service that hosts your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: These last two paragraphs feel a little tacked on after the pointers to other docs. You could try:

  • Moving these two paragraphs to just after the "Ruby on Rails..." paragraph, so the parallel structure with other explanatory paragraph is clear
  • Moving the admonition and "To learn more..." paragraph to the end. Could also consider putting this in an admonition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shuffled paragraphs


When connecting to an Atlas cluster, you must specify the database that
you want to interact with as the default database in your connection string.
You must add the database name to your connection string **after the hostname**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I try to use italics for emphasis since we often use bold to introduce new terms (either one is consistent with the style guide)

@rustagir rustagir requested a review from mongoKart October 15, 2024 15:24
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ 1 suggestion!

Ruby. By using {+odm+}, you can easily interact with your data and
create flexible data models.

Ruby on Rails, or Rails, is a web application framework for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: You could just say "Rails" or "Ruby on Rails" here, since you've already introduced both terms

@rustagir rustagir merged commit 9a1918c into mongodb:standardized Oct 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants