DOCSP-42753: specify query part 1 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
requested changes
Oct 29, 2024
Comment on lines
40
to
44
| functionalities. Some sections might also use the ``Manager`` model, | ||
| which represents a person who manages a given band. | ||
|
|
||
| ``Show`` model, which | ||
| represents a live performance by a certain band or musical group. |
There was a problem hiding this comment.
This last sentence seems unfinished. Should it maybe go with the one before?
Suggested change
| functionalities. Some sections might also use the ``Manager`` model, | |
| which represents a person who manages a given band. | |
| ``Show`` model, which | |
| represents a live performance by a certain band or musical group. | |
| functionalities. Some sections might also use the ``Manager`` model, | |
| which represents a person who manages a given band, or a ``Show`` model, which | |
| represents a live performance by a certain band or musical group. |
There was a problem hiding this comment.
Oops, yes its a WIP because Idk what other types will be used on this page
Comment on lines
83
to
84
| Condition Syntax | ||
| ---------------- |
There was a problem hiding this comment.
This title seems a bit unclear and I don't think it adequately describes what this section is talking about. I think changing it to something like "Create a Query Filter" or something similar might be more fitting? Open to other ideas too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42753
Staging - https://deploy-preview-58--docs-mongoid.netlify.app/interact-data/specify-query/
Self-Review Checklist