-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-44946 TOC Relabel #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave off "Getting Started" and just use the product name for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like 'Sinatra App'? Just so readers have a hint of what they're getting into and might be more attracted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left with just the product name, but let me know if including 'App' makes sense to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling is that if you're using this Driver, you probably know your options and don't think this is about Frank Sinatra. I misread your message and approved the PR before reading that you wanted to put 'App' in. Sorry!!
* DOCSP-44946 TOC Relabel * Mike's suggestion * sarah's suggestion (cherry picked from commit 884292f)
* DOCSP-44946 TOC Relabel * Mike's suggestion * sarah's suggestion (cherry picked from commit 884292f) Co-authored-by: lindseymoore <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44946
Staging - https://deploy-preview-62--docs-mongoid.netlify.app/
Self-Review Checklist