-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-42741: config pages #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…OCSP-42741-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor adjustments:
source/configuration/app-config.txt
Outdated
- ``false`` (*default*): {+odm+} uses ``Time.zone`` to set the time | ||
zone of time values are loaded from database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few ways this could be corrected. This is my best guess:
- ``false`` (*default*): {+odm+} uses ``Time.zone`` to set the time | |
zone of time values are loaded from database. | |
- ``false`` (*default*): {+odm+} uses ``Time.zone`` to set the time | |
zone as time values are loaded from the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
source/configuration/app-config.txt
Outdated
To set TLS context hooks, add a ``Proc`` to the ``Mongo.tls_context_hooks`` | ||
array, which can be done in an initializer. The following example adds a hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit awkward:
To set TLS context hooks, add a ``Proc`` to the ``Mongo.tls_context_hooks`` | |
array, which can be done in an initializer. The following example adds a hook | |
To set TLS context hooks, add a ``Proc`` to the ``Mongo.tls_context_hooks`` | |
array. This can be done in an initializer. The following example adds a hook |
source/configuration/app-config.txt
Outdated
- `Zstandard <https://facebook.github.io/zstd/>`__: To use ``zlib`` | ||
compression, you must install the `zstd-ruby | ||
<https://rubygems.org/gems/zstd-ruby>`__ library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to the top of the list since it's our recommendation:
- `Zstandard <https://facebook.github.io/zstd/>`__: To use ``zlib`` | |
compression, you must install the `zstd-ruby | |
<https://rubygems.org/gems/zstd-ruby>`__ library. | |
- `Zstandard <https://facebook.github.io/zstd/>`__ (recommended): To use ``zlib`` | |
compression, you must install the `zstd-ruby | |
<https://rubygems.org/gems/zstd-ruby>`__ library. | |
- produces the highest compression with the same CPU consumption |
source/configuration/app-config.txt
Outdated
is supported by the MongoDB Server. We recommend using the ``zstd`` | ||
compressor because it produces the highest compression at the same CPU | ||
consumption compared to the other compressors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this recommendation into the list above.
is supported by the MongoDB Server. We recommend using the ``zstd`` | |
compressor because it produces the highest compression at the same CPU | |
consumption compared to the other compressors. | |
is supported by the MongoDB Server. |
Use the ``after_fork`` hook to reconnect clients in the workers. Use | ||
the ``before_fork`` hook to close clients in the parent process. To |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would just reverse these two sentences:
Use the ``after_fork`` hook to reconnect clients in the workers. Use | |
the ``before_fork`` hook to close clients in the parent process. To | |
Use the ``before_fork`` hook to close clients in the parent process. Use the ``after_fork`` hook to reconnect clients in the workers. To |
To configure either {+odm+} or driver logger differently from the Rails | ||
logger, use an initializer as shown in the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To configure either {+odm+} or driver logger differently from the Rails | |
logger, use an initializer as shown in the following code: | |
To configure either the {+odm+} or driver logger differently from the Rails | |
logger, use an initializer as shown in the following code: |
include Mongo::QueryCache::Middleware::ActiveJob | ||
end | ||
|
||
You can also for a specific job class, as shown in the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also for a specific job class, as shown in the following code: | |
You can also enable it for a specific job class, as shown in the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
* DOCSP-42732: qs * fix * wip * remove action * NR suggestion * DOCSP-42732: qs download * wip * adapt for sinatra * vale fix * snooty landing page * MW PR fixes 1 * DOCSP-42733: atlas prep qs * MW PR fixes 1 * DOCSP-42735: configure cxn * small fix - vale * JS PR fixes 1 * DOCSP-44008: read/write sinatra quickstart * fixes * NR PR fixes 1 * DOCSP-43961: rails qs * vale * ordering * small fix * MW PR fixes 1 * small fixes * MW PR fixes 2 * DOCSP-44647: add to existing app * fix vale action * vale fixes * depth * MW PR fixes 1 * fixes * DOCSP-42745: interact with data drawer * tags * fix vale action * remove extra word Co-authored-by: Nora Reidy <[email protected]> * DOCSP-42753: specify query part 1 * vale * title * code edits * MW PR fixes 2 * DOCSP-44849: modify results * vale * JS PR fixes 1 * fix * fix * list fixes * MW PR fixes 1 * DOCSP-44954: scoping * add landing page * link * vale * highlighting * DOCSP-44821: specify a query pt 2 * MR PR fixes 1 * wip * wip * wip * small fixes * DOCSP-42767 Aggregation (#57) * DOCSP-42774: transactions * vale * link text * MW PR fixes 1 * MR PR fixes 1 * DOCSP-45306: model data drawer * DOCSP-45330: inheritance (WIP) * MR PR fixes 2 * try using roles * wip * vale * add label * fixes * fix * small fixes - MW * DOCSP-45358: documents * fix * wip * wip * DR tech review 1 * page fmt * page fmt * SA PR fixes 1 * MR PR fixes 1 * DR small fix Co-authored-by: Dmitry Rybakov <[email protected]> * DOCSP-45360: nested attributes (#71) * DOCSP-45360: nested attributes * vale + fixes * fixes * NR PR fixes 1 * DOCSP-45362: text search (#72) * DOCSP-45362: text search * wip * vale * MM PR fixes 1 * DOCSP-45436 Field Behaviors page (#68) * DOCSP-45363: validation (#73) * DOCSP-45363: validation * keywords * wip * SA PR fixes 1 * DOCSP-44794 Field Types (#69) * DOCSP-45357 Sharding Configuration (#76) * DOCSP-42762: Indexes (#74) * DOCSP-45367 Associations pt. 1 (#79) * DOCSP-45368: Persistence Configuration (#77) * DOCSP-45361: callbacks (#75) * DOCSP-45361: callbacks * wip * wip * wip * NR PR fixes 1 * DOCSP-45364: CRUD pt 1 (#81) * checkpoint * checkpoint 2 * woohoo first pass * indent * Edits * updates * vale chekcs * RR PR fixes 1 * fix code file * code fixes * RM PR fixes 1 --------- Co-authored-by: rustagir <[email protected]> * DOCSP-45110: queries subsections (#80) * DOCSP-45110: queries misc sections * wip: * vale * MR PR fixes 1 * GM PR fixes 1 * DOCSP-46072 Associations part 2 (#82) * DOCSP-46394: CRUD remaining sections (#83) * DOCSP-46394: CRUD remaining sections * vale fixes * JS PR fixes 1 * DOCSP-46213: bump to rails 8 and remove old tuts (#84) * DOCSP-45356: i&h + code doc (#86) * DOCSP-45356: i&h + code doc * remove contributing * vale fixes * link fix * vale fixes + RM comment * DOCSP-42770: release notes/whats new (#87) * DOCSP-42770: release notes/whats new * fixes * fixes * DOCSP-42773: api links (#88) * DOCSP-42773: api links * fix * link fixes * DOCSP-42772: compatibility (#90) * DOCSP-42772: compatibility * small fix * small fix * SA PR fixes 1 * delete files for old build system * column width adjustment * DOCSP-45366 Encryption (#89) * DOCSP-42741: config pages (#91) * DOCSP-42741: config * wip * wip * some vale fixes * RM PR fixes 1 * small fix * DOCSP-46555: rails integration (#92) * wip * DOCSP-46555: rails integration * RM PR fixes 1 * DOCSP-45359 External Resources (#94) * add additional resources page * edits * feedback * DOCSP-42743 Collection config (#95) * DOCSP-42730: landing page (#96) * DOCSP-42730: landing page * MW PR fixes 1 * small fix * small fix * small fix * DOCSP-46121: cleanup (#97) * cleanup * copy compat action * redirects * MW PR fixes 1 * add index section * change vs in redirects --------- Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Jordan Smith <[email protected]> Co-authored-by: Dmitry Rybakov <[email protected]> Co-authored-by: Maya Raman <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42741
Staging - multiple pages from https://deploy-preview-91--docs-mongoid.netlify.app/configuration/
Self-Review Checklist