-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-46413: Compatibility #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-46413: Compatibility #145
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snooty.toml
Outdated
driver-short = "PyMongo" | ||
driver-long = "PyMongo, the MongoDB synchronous Python driver," | ||
driver-async = "PyMongo Async" | ||
django-odm = "MongoDB Backend for Django" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be "Django MongoDB Backend" ?
source/django-compatibility.txt
Outdated
|
||
.. sharedinclude:: dbx/compatibility-table-legend.rst | ||
|
||
.. include:: /includes/mongodb-compatibility-table-pymongo.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we required to list the PyMongo<>MongoDB compatibility information here or can we link to it instead? At a glance, it looks overwhelming, and the most important message to convey is Django 5.x == Django MongoDB 5.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine just linking to it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
source/django-compatibility.txt
Outdated
{+django-odm+} for use with a specific version of Python. | ||
The first column lists the ODM version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I think this is clear by the table headers
{+django-odm+} for use with a specific version of Python. | |
The first column lists the ODM version. | |
{+django-odm+} for use with a specific version of Python. |
Moved to the Django repo: mongodb/docs-django#5 |
Pull Request Info
PR Reviewing Guidelines
Note: This PR will move to the docs-django repo
JIRA - https://jira.mongodb.org/browse/DOCSP-46413
Staging - https://deploy-preview-145--docs-pymongo.netlify.app/django-compatibility/
Self-Review Checklist