Skip to content

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jan 13, 2025

Pull Request Info

PR Reviewing Guidelines
Note: This PR will move to the docs-django repo

JIRA - https://jira.mongodb.org/browse/DOCSP-46413
Staging - https://deploy-preview-145--docs-pymongo.netlify.app/django-compatibility/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit e72ba09
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/678828a2f450cd000882f969
😎 Deploy Preview https://deploy-preview-145--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

snooty.toml Outdated
driver-short = "PyMongo"
driver-long = "PyMongo, the MongoDB synchronous Python driver,"
driver-async = "PyMongo Async"
django-odm = "MongoDB Backend for Django"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be "Django MongoDB Backend" ?


.. sharedinclude:: dbx/compatibility-table-legend.rst

.. include:: /includes/mongodb-compatibility-table-pymongo.rst

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we required to list the PyMongo<>MongoDB compatibility information here or can we link to it instead? At a glance, it looks overwhelming, and the most important message to convey is Django 5.x == Django MongoDB 5.x.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine just linking to it!

@norareidy norareidy requested a review from aclark4life January 14, 2025 18:38
Copy link

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 45 to 46
{+django-odm+} for use with a specific version of Python.
The first column lists the ODM version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think this is clear by the table headers

Suggested change
{+django-odm+} for use with a specific version of Python.
The first column lists the ODM version.
{+django-odm+} for use with a specific version of Python.

@norareidy
Copy link
Collaborator Author

Moved to the Django repo: mongodb/docs-django#5

@norareidy norareidy closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants