DOCSP-43420: Client bulk write #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rachel-mack
approved these changes
Feb 19, 2025
source/write/bulk-write.txt
Outdated
Comment on lines
111
to
116
| - Namespace in which to perform the update. This argument is optional if | ||
| you perform the bulk operation on a single collection. | ||
| - **Query filter** that specifies the criteria used to match documents in your collection. | ||
| - Update operation you want to perform. For more information about update | ||
| operations, see the :manual:`Field Update Operators | ||
| </reference/operator/update-field/>` guide in the {+mdb-server+} manual. |
There was a problem hiding this comment.
You could do this or make this a table:
Suggested change
| - Namespace in which to perform the update. This argument is optional if | |
| you perform the bulk operation on a single collection. | |
| - **Query filter** that specifies the criteria used to match documents in your collection. | |
| - Update operation you want to perform. For more information about update | |
| operations, see the :manual:`Field Update Operators | |
| </reference/operator/update-field/>` guide in the {+mdb-server+} manual. | |
| - Namespace: Where to perform the update. This argument is optional if | |
| you perform the bulk operation on a single collection. | |
| - Query filter: Specifies the criteria used to match documents in your collection. | |
| - Update operation: The operation you want to perform. For more information about update | |
| operations, see the :manual:`Field Update Operators | |
| </reference/operator/update-field/>` guide in the {+mdb-server+} manual. |
Same of the proceeding operation parameters.
Comment on lines
+217
to
+222
| When {+driver-short+} runs a bulk operation, it uses the ``write_concern`` of the | ||
| collection or client on which the operation is running. You can also set | ||
| a write concern for the operation when using the ``MongoClient.bulk_write()`` | ||
| method. The driver reports all write concern errors after attempting all operations, | ||
| regardless of execution order. | ||
|
|
There was a problem hiding this comment.
Add link to Write Concern in the server manual
source/write/bulk-write.txt
Outdated
Comment on lines
278
to
279
| operation. If you don't specify any additional options, the driver does not customize | ||
| the bulk write operation. |
There was a problem hiding this comment.
I realize you didn't add this, but it's an odd thing to explicitly call out, so I think we should remove it.
Suggested change
| operation. If you don't specify any additional options, the driver does not customize | |
| the bulk write operation. | |
| operation. |
caseyclements
suggested changes
Feb 21, 2025
source/write/bulk-write.txt
Outdated
|
|
||
| You can use bulk operations to perform multiple write operations on | ||
| a collection. You can also call bulk operations on your client, | ||
| which allows you to perform bulk writes across multiple namespaces. |
There was a problem hiding this comment.
I'd probably say, "Both collections and clients have bulk_write methods. Using the latter allows you to perform bulk writes across multiple namespaces."
There was a problem hiding this comment.
I reworded, let me know what you think!
norareidy
added a commit
that referenced
this pull request
Feb 24, 2025
* DOCSP-43420: Client bulk write * versions * output * error type * wording * RM feedback * admonition * CC feedback (cherry picked from commit 7609c5a)
norareidy
added a commit
that referenced
this pull request
Feb 24, 2025
* DOCSP-43420: Client bulk write * versions * output * error type * wording * RM feedback * admonition * CC feedback (cherry picked from commit 7609c5a)
norareidy
added a commit
that referenced
this pull request
Feb 24, 2025
* DOCSP-43420: Client bulk write * versions * output * error type * wording * RM feedback * admonition * CC feedback (cherry picked from commit 7609c5a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43420
Staging Links
Self-Review Checklist