Skip to content

DOCSP-48323: Causal consistency feedback #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Mar 14, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48323

Staging Links

  • write/transactions
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Mar 14, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 888c394
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67d492555cecd20008d2089c
    😎 Deploy Preview https://deploy-preview-224--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @@ -90,7 +95,7 @@ consistent sessions provide:
    ``delete_one()`` to delete the retrieved document, the driver runs the find
    operation first.

    In a causally consistent session, MongoDB ensures a causal relationship between the
    In a causally consistent session, MongoDB only guarantees causal consistency between the
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    In a causally consistent session, MongoDB only guarantees causal consistency between the
    In a causally consistent session, MongoDB guarantees causal consistency between only the

    Comment on lines 62 to 63
    A client session guarantees causal consistency even if it is not used within a
    transaction.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    i'm not sure exactly what this means; maybe add some explanation?

    @mcmorisi mcmorisi requested a review from mongoKart March 14, 2025 20:32
    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM! Thanks for brainstorming

    @mcmorisi mcmorisi requested a review from NoahStapp March 14, 2025 20:36
    @mcmorisi mcmorisi closed this Mar 24, 2025
    @mcmorisi mcmorisi deleted the DOCSP-48323-causal-consistency-feedback branch March 24, 2025 13:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants