DOCSP-48168: Async examples for Databases and Collections/Run Command #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mcmorisi
commented
Mar 18, 2025
NoahStapp
suggested changes
Mar 24, 2025
|
|
||
| collection_list = await database.list_collection_names() | ||
|
|
||
| async for c in collection_list: |
There was a problem hiding this comment.
Suggested change
| async for c in collection_list: | |
| for c in collection_list: |
list_collection_names() returns a list, so we can iterate without the async here.
source/databases-collections.txt
Outdated
|
|
||
| from typing import TypedDict | ||
| from pymongo import AsyncMongoClient | ||
| from pymongo.database import Database |
There was a problem hiding this comment.
Suggested change
| from pymongo.database import Database | |
| from pymongo.asynchronous.database import Database |
|
|
||
| from typing import TypedDict | ||
| from pymongo import AsyncMongoClient | ||
| from pymongo.collection import Collection |
There was a problem hiding this comment.
Suggested change
| from pymongo.collection import Collection | |
| from pymongo.asynchronous.collection import Collection |
NoahStapp
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48168
Staging Links
Self-Review Checklist