Skip to content

DOCSP-50383: Add links to preview page #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jun 16, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50383

Staging Links

  • integrations
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Jun 16, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit 6457b93
    🔍 Latest deploy log https://app.netlify.com/projects/docs-pymongo/deploys/68504056d16fcd00081fdb4d
    😎 Deploy Preview https://deploy-preview-273--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM! Let me know if you want another look

    @@ -93,7 +93,7 @@ aggregation operations and indexes.

    {+django-odm+} is in Public Preview and intended for evaluation purposes only.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    {+django-odm+} is in Public Preview and intended for evaluation purposes only.
    {+django-odm+}, a backend database that uses the PyMongo driver, is in Public Preview and intended for evaluation purposes only.

    S: I would include how django is related to pymongo. I was confused at first why there was a django note on the pymongo page. If you think users will already get why this note is here, you can disregard.

    Copy link
    Collaborator Author

    @norareidy norareidy Jun 16, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since this callout is in the Django section of the Integrations page, which describes the pymongo/django relationship, I don't think it needs this clarification. But I think the banner on the PyMongo landing page could use this additional info! I'll add it there

    @norareidy norareidy merged commit 4c20979 into mongodb:master Jun 16, 2025
    6 checks passed
    @norareidy norareidy deleted the DOCSP-50383-preview-link branch June 16, 2025 16:08
    norareidy added a commit that referenced this pull request Jun 16, 2025
    * DOCSP-50383: Add links to preview page
    
    * LM feedback
    
    (cherry picked from commit 4c20979)
    norareidy added a commit that referenced this pull request Jun 16, 2025
    * DOCSP-50383: Add links to preview page
    
    * LM feedback
    
    (cherry picked from commit 4c20979)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants