DOCSP-42254: Fix GridFS code #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Aug 7, 2024
source/includes/gridfs/gridfs.py
Outdated
Comment on lines
1
to
5
| # start create bucket | ||
| client = MongoClient("<connection string>") | ||
| db = client["db"] | ||
| bucket = gridfs.GridFSBucket(db) | ||
| # end create bucket |
There was a problem hiding this comment.
Q: why is the code in this file indented?
source/includes/gridfs/gridfs.py
Outdated
Comment on lines
12
to
15
| with bucket.open_upload_stream( | ||
| "my_file", chunk_size_bytes=1048576, | ||
| metadata={"contentType": "text/plain"}) as grid_in: | ||
| grid_in.write("data to store") |
There was a problem hiding this comment.
S: i think the line formatting needs to be corrected here
norareidy
added a commit
that referenced
this pull request
Aug 8, 2024
* DOCSP-42254: Fix GridFS code * edit wording * fixes * reword * dedent * RR feedback (cherry picked from commit 7e64c10)
norareidy
added a commit
that referenced
this pull request
Aug 8, 2024
* DOCSP-42254: Fix GridFS code * edit wording * fixes * reword * dedent * RR feedback (cherry picked from commit 7e64c10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42254
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/pymongo/DOCSP-42254-fix-gridfs-code/write/gridfs/
Self-Review Checklist