Adding ability to add 'extraManifests'#212
Adding ability to add 'extraManifests'#212JunaidChaudry wants to merge 3 commits intomongodb:mainfrom
Conversation
|
Closes #213 |
229817b to
6c9f51e
Compare
|
Can a reviewer kindly review this? |
|
@slaskawi Can you please review this one as well? The feature aligns with many other opensource helm charts (e.g. grafana, prometheus, argo-cd, etc.), to support extra k8s manifests using the values files. |
d330cc9 to
9fd8540
Compare
slaskawi
left a comment
There was a problem hiding this comment.
Overall, I'm fine with extraObjects. We're seen this approach in Grafana and Argo, and we see it useful.
I'm not sure about adding annotations on Service Accounts. Could you please provide us examples why it's necessary and extract this into a separate PR?
|
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
|
@JunaidChaudry Could you please check my comment and rebase this PR? |
|
@slaskawi Apologies for the VERY long delay. I have rebased with main, and please also check out my comment around serviceaccount annotations, and why I think it should be included. |
|
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).