feat(ipa0102): ResourceID guidelines elaboration#36
Conversation
yelizhenden-mdb
requested review from
andmatei,
andreaangiolillo,
drinkbird,
lovisaberggren,
matt-condon,
saisundar and
wtrocki
lovisaberggren
left a comment
lovisaberggren
left a comment
There was a problem hiding this comment.
A few nits/suggestions for the examples, and to keep the language a bit more consistent with the overall IPA, thanks!
ipa/general/0102.md
Outdated
| - Example: for collection `clusters`, the resource ID should be | ||
| `clusterId` |
There was a problem hiding this comment.
[Nit] Maybe use a different example here, since we use clusterName as example above
There was a problem hiding this comment.
Maybe going with groupId is better because I am not comfortable giving name as an example 🥲
There was a problem hiding this comment.
clusterName reminded me that I need to add a suggestion to prefer system-generated unique identifiers than the human-readable identifiers. Could you double-check the wording, do you have any suggestions/concerns?
There was a problem hiding this comment.
Nice! Only suggestion is to use "server" instead of "system"
Co-authored-by: Lovisa Berggren <59226031+lovisaberggren@users.noreply.github.com>
Co-authored-by: Lovisa Berggren <59226031+lovisaberggren@users.noreply.github.com>
Co-authored-by: Lovisa Berggren <59226031+lovisaberggren@users.noreply.github.com>
lovisaberggren
left a comment
lovisaberggren
left a comment
There was a problem hiding this comment.
Thanks! Two nits on using "server" instead of "system"
Co-authored-by: Lovisa Berggren <59226031+lovisaberggren@users.noreply.github.com>
Co-authored-by: Lovisa Berggren <59226031+lovisaberggren@users.noreply.github.com>
2 participants
No description provided.