Skip to content

Owner key for morphTo relations #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2024
+11 −2
Merged

Owner key for morphTo relations #3162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f157cc
Use owner key if it was set;
hans-thomas Sep 27, 2024
327a514
Add tests;
hans-thomas Sep 27, 2024
d5bf3a2
apply phpcbf formatting
hans-thomas Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Relations/MorphTo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ protected function getResultsByType($type)
{
$instance = $this->createModelByType($type);

$key = $instance->getKeyName();
$key = $this->ownerKey ?? $instance->getKeyName();

$query = $instance->newQuery();

Expand Down
11 changes: 10 additions & 1 deletion tests/RelationsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,11 +634,13 @@ public function testMorph(): void
$photo = Photo::first();
$this->assertEquals($photo->hasImage->name, $user->name);

// eager load
$user = User::with('photos')->find($user->id);
$relations = $user->getRelations();
$this->assertArrayHasKey('photos', $relations);
$this->assertEquals(1, $relations['photos']->count());

// inverse eager load
$photos = Photo::with('hasImage')->get();
$relations = $photos[0]->getRelations();
$this->assertArrayHasKey('hasImage', $relations);
Expand All @@ -648,7 +650,7 @@ public function testMorph(): void
$this->assertArrayHasKey('hasImage', $relations);
$this->assertInstanceOf(Client::class, $photos[1]->hasImage);

// inverse
// inverse relationship
$photo = Photo::query()->create(['url' => 'https://graph.facebook.com/hans.thomas/picture']);
$client = Client::create(['name' => 'Hans Thomas']);
$photo->hasImage()->associate($client)->save();
Expand All @@ -666,6 +668,13 @@ public function testMorph(): void
$this->assertInstanceOf(Client::class, $photo->hasImageWithCustomOwnerKey);
$this->assertEquals($client->cclient_id, $photo->has_image_with_custom_owner_key_id);
$this->assertEquals($client->id, $photo->hasImageWithCustomOwnerKey->id);

// inverse eager load with custom ownerKey
$photos = Photo::with('hasImageWithCustomOwnerKey')->get();
$check = $photos->last();
$relations = $check->getRelations();
$this->assertArrayHasKey('hasImageWithCustomOwnerKey', $relations);
$this->assertInstanceOf(Client::class, $check->hasImageWithCustomOwnerKey);
}

public function testMorphToMany(): void
Expand Down
Loading